[zeroibis]

Which is better for performance?

is it better to have:

if(condition1 && condition2)
{

}

or

if(condition1)
{
if(condition2)
{

}
}

Also is this still the case if doing so requires extra variable creation? Or in some cases even work preformed to the variable before check? (imagine if we also wanted to add something to value first or if we were trying to get an event string)

For example:

if(condition1)
{
new value=somemethod(var);
if(value<10)
{

}
}

OR

new value=somemethod(var);
if(condition1 && value<10)
{

}

So what do we do in order to ensure best performance? Thanks for the help

[berni]

In the first scenario there isn't really an important difference, besides the second one probably results in a bit more bytecode.

In The second scenario the first one can be slightly faster (depending on how much CPU time somemethod() needs) because the function will only be called when condition1 is true. But in most cases this also shouldn't make too much difference.

There are things that can take much much more CPU time, like calling FindConVar() every frame

[zeroibis]

Ok cool,

I also assume that I should be going in order of least costly check to most costly when using && under the assumption that once something returns false the operation will stop and no more of the remaining && will be evaluated.

I have a great deal of plugins preforming a lot of if statements within hurt events so I really want to make sure that the functions are as optimized as possible.

[Powerlord]

Originally Posted by zeroibis Ok cool, I also assume that I should be going in order of least costly check to most costly when using && under the assumption that once something returns false the operation will stop and no more of the remaining && will be evaluated.

That is correct. That's why most languages support short-circuiting operators.

You also see them used a lot when you need to check if a value is valid before using it. For instance:

PHP Code:

if (g_Cvar_SomeCvar != INVALID_HANDLE && GetConVarBool(g_Cvar_SomeCvar))
{
} 


[zeroibis]

Thanks, and great example!