[StealthGus]

I'm trying to make just a simple kill counter plugin. This is semi-one of my first times messing around with SQL inside of sourcemod. I know it looks super rough and it's mostly because my original code didn't work so I started trying to piece together from other plugins I had been finding.

Any help would be appreciated, thanks!

Spoiler

#pragma semicolon 1

#define DEBUG

#define PLUGIN_AUTHOR "StealthGus"
#define PLUGIN_VERSION "1.0"

#include <sourcemod>
#include <sdktools>
#include <cstrike>
#include <sdkhooks>


EngineVersion g_Game;

Handle db;

public Plugin myinfo = 
{
	name = "Terrorist Kill Counter",
	author = PLUGIN_AUTHOR,
	description = "Counts kills commited by a Terrorist",
	version = PLUGIN_VERSION,
	url = "https://"
};

public void OnPluginStart()
{
	g_Game = GetEngineVersion();
	if(g_Game != Engine_CSGO && g_Game != Engine_CSS)
	{
		SetFailState("This plugin is for CSGO/CSS only.");	
	}
	HookEvent("player_death", EventPlayerDeath);
	InitDB(db);
}

void InitDB(Handle dbhandle) {
	
	char errormsg[255];
	
	dbhandle = SQL_Connect("terroristkillcounter", true, errormsg, sizeof(errormsg));
	
	if(dbhandle == INVALID_HANDLE){
		SetFailState(errormsg);
	}
	
	char Query[255];
	Format(Query, sizeof(Query), "CREATE TABLE IF NOT EXISTS terroristkillcounter (steamid TEXT, name TEXT, kills INT)");

	SQL_LockDatabase(dbhandle);
	SQL_FastQuery(dbhandle, Query);
	SQL_UnlockDatabase(dbhandle);
}

public OnClientConnected(int client){
	char clientID[64];
	char clientName[64];
	//GetClientName(client, clientName, sizeof(clientName));
	GetClientAuthId(client, AuthId_SteamID64, clientID , sizeof(clientID));
	char Query[255];
	Format(Query, sizeof(Query), "INSERT IGNORE INTO terroristkillcounter (steamid, kills, name) VALUES ('%s', '0', '%s')", clientID, clientName);
	SQL_FastQuery(db, Query);
	
}

public Action EventPlayerDeath(Event event, const char[] name, bool dontBroadcast){
	new client;
	char attacker;
	int attackerCredits;
	char attackerID[64];
	char attackerName[2];
	char attackertest;
	client = GetClientOfUserId(GetEventInt(event, "attacker"));
	GetClientAuthId(client, AuthId_SteamID64, attackerID, sizeof(attackerID));
	attacker = GetEventInt(event, "attacker");
	attackertest = GetClientOfUserId(attacker);
	GetClientName(attackertest, attackerName, sizeof(attackerName));
	char Query[255];
	Format(Query, sizeof(Query), "SELECT kills FROM terroristkillcounter WHERE steamid ='%s';", attackerID);
	Handle queryH = SQL_Query(db, Query);
	attackerCredits = SQL_FetchInt(queryH, 1);
	PrintToChatAll("%s HAS %i KILLS", attackerName, attackerCredits);
	new clients = 0;
	for(new i=1;i<=MaxClients; i++ ) {
        if(IsClientInGame(i)){
            clients++;
        }

    }
    if (clients > 6){
    	updateCredits(attackerID, attackerName, attackerCredits);
    }
  	else {
  		PrintToChat(client, "\x04[\x01eGO\x04]\x01 Not enough people in the server (%s/6)", clients);
 	}
    
    
}

void updateCredits (char[] steamid, char[] name, int attackerCreds) {
	
	attackerCreds += 1;
	
	char Query[255];
	Format(Query, sizeof(Query), "UPDATE terroristkillcounter SET kills=%i, name=%s, WHERE steamid=%s", attackerCreds, name, steamid);
	SQL_TQuery(db, SQL_ErrorCheckCallBack, Query);
	
}

public SQL_ErrorCheckCallBack(Handle owner, Handle hndl, const char[] error, any:data)
{
	// This is just an errorcallback for function who normally don't return any data
	if(hndl == INVALID_HANDLE)
	{
		SetFailState("Query failed! %s", error);
	}
}

[8guawong]

and what do you need help with...

[Mitchell]

Originally Posted by 8guawong and what do you need help with...

just a quick glance at the code what issue he is probably facing is that when ever a player connects it creates a new row for the client starting at zero, meaning that there is multiple rows for the same steamid.
Also he's missing the 'Query' callback.

[8guawong]

Originally Posted by Mitchell just a quick glance at the code what issue he is probably facing is that when ever a player connects it creates a new row for the client starting at zero, meaning that there is multiple rows for the same steamid. Also he's missing the 'Query' callback.

[StealthGus]

Oh geez, I did a great job explaining didn't I?

SQL Never fires. I can't get it to even add a row. I'm aware I'll have an issue with a creating a new row every connect but that's easily fixable with making the steamID row unique (right?). But for whatever reason it seems that my DB is not initializing in any way.

[Neuro Toxin]

First thing I notice is OnClientConnected is not the right place to pull a clients steamid.

Use OnClientFullyAuthorized? I think it is...

[Mitchell]

You need to wait on the thread query first for it to SELECT how many kills the player has, then update the kill count +1.

[headline]

You shouldn't be updating SQL after every kill, just do "SELECT * FROM table WHERE steamid ='%s'" every connection, store their kill count in a global var, and then update when they leave. You can also use SQL_GetRowCount there in order to tell if they even exist in the db in the first place. Consider using Threaded queries, aswell.

Is your table even being created? That's a good place to start

Originally Posted by Neuro Toxin Use OnClientFullyAuthorized? I think it is...

OnClientPostAdminCheck is a good place for a guaranteed steamid

[Neuro Toxin]

Originally Posted by Mitchell You need to wait on the thread query first for it to SELECT how many kills the player has, then update the kill count +1.

You can use `column`=`column`+1 in MySQL

[StealthGus]

Originally Posted by Headline You shouldn't be updating SQL after every kill, just do "SELECT * FROM table WHERE steamid ='%s'" every connection, store their kill count in a global var, and then update when they leave. You can also use SQL_GetRowCount there in order to tell if they even exist in the db in the first place. Consider using Threaded queries, aswell. Is your table even being created? That's a good place to start OnClientPostAdminCheck is a good place for a guaranteed steamid

Hmmm, alright I'll check that.

Yes the table is being created.