[Mysterious]

Hello,

i wanted to concatenate two strings but i had to allocate the memory on my own but the server crashed all the time.
I am using the standard serverplugin_empty as template and tried these ways:

1. char *lol = (char *)calloc(strlen(term)+2,sizeof(char));
   free(lol);
2. char *lol = new char[strlen(term)+2];
    delete lol;

Both ways already fail on allocation.
Actually they don't fail but the memory access creates some errors.
Symptoms are:
- The memory usage raises really fast.
- memory raise stops at about 90.000K
- crash: "The command at "0x11507b19" refers to the memory at "0x00000010". The operation "read" couldn't be executed.

Am I so incredible stupid or is something going badly wrong?
I guess I am the fault.
Please help me:>

Yours
Mysterious

[recon0]

You're doing something seriously wrong...

PHP Code:

char *newStr = new char[strlen(str1) + strlen(str2)];
strcpy(newStr, str1);
strcat(newStr, str2); 


[Keeper]

I actually tried your code in one of my plugins and it worked fine. I had string sizes up to a 1MB. Never crashed. I'm betting it's not the allocation, but more likely something to do with the concatenation ( since it's a read error ). I would use recon0's method. Also, make sure you test lol ... if it had an issue allocating the memory it would return NULL.

[PM]

Also make sure you're not doing this every frame on large strings without ever freeing memory.

[Mysterious]

Oh my god >.<
I did a stupid mistake:

        if(g_SHPtr->GetStatus() == MRES_OVERRIDE)
        {
        }
        else{
            if(strlen(META_RESULT_ORIG_RET(const char*)) >6)
            {
                if(checkpathstart(META_RESULT_OVERRIDE_RET(const char*),"models")){}
            }
        }

I copy-pasted some code. It easy to understand that it's impossible to use a value that doesn't exist...
So it wasn't about memory allocation.

Sorry for bothering you^^
and thanks anyways.

[Chrisber]

It must be delete[], not delete on arrays.

Chris

[Mysterious]

Oh!
Thank you Chrisber.