[valio_skull]

Can someone tell me what is wrong with this ?
I'm just trying to make it work by map cfg file...

PHP Code:

#include <sourcemod>
#include <sdktools>

#define PLUGIN_VERSION "1.1"

new Handle:g_CVarEnabled;

public Plugin myinfo =
{
    name = "Round Exec by Mado",
    author = "Mado",
    description = "none",
    version = PLUGIN_VERSION,
    url = "http://www.bluegames.ro/forum/"
}

public OnPluginStart()
{
    g_CVarEnabled = CreateConVar("sm_roundexec_enable", "1", "<1/0> Set to 1 to enable plugin.");
    HookEvent("round_start", RoundStart, EventHookMode_Post);
    HookEvent("round_end", RoundEnd, EventHookMode_Post);
}

public Action:RoundStart(Handle:event, const String:name[], bool:dontBroadcast) {
    decl String:file[PLATFORM_MAX_PATH], String:curmap[PLATFORM_MAX_PATH];
    GetCurrentMap(curmap, sizeof(curmap));
    {
        if (GetConVarInt(g_CVarEnabled)){
        ServerCommand("exec round_exec/%s_start.cfg", curmap);
        }
    }
    if (!FileExists(file))
    {
        if (GetConVarInt(g_CVarEnabled)){
            ServerCommand("exec round_exec/round_start.cfg");
        }
    }
}

public Action:RoundEnd(Handle:event, const String:name[], bool:dontBroadcast) {
    decl String:file[PLATFORM_MAX_PATH], String:curmap[PLATFORM_MAX_PATH];
    GetCurrentMap(curmap, sizeof(curmap));
    {
        if (GetConVarInt(g_CVarEnabled)){
        ServerCommand("exec round_exec/%s_end.cfg", curmap);
        }
    }
    if (!FileExists(file))
    {
        if (GetConVarInt(g_CVarEnabled)){
            ServerCommand("exec round_exec/round_end.cfg");
        }
    }
} 


[valio_skull]

I've checked, when ti has the %s_start.cfg and %s_end.cfg files it exec the round_start.cfg and round_end.cfg . I want it to exec only the %s_start.cfg and %s_end.cfg

[Powerlord]

This block looks funny:

    { 
        if (GetConVarInt(g_CVarEnabled)){ 
        ServerCommand("exec round_exec/%s_start.cfg", curmap); 
        } 
    } 
    if (!FileExists(file)) 
    { 
        if (GetConVarInt(g_CVarEnabled)){ 
            ServerCommand("exec round_exec/round_start.cfg"); 
        } 
    }

It should probably be

    Format(file, sizeof(file). "round_exec/%s_start.cfg", curmap);

    if (GetConVarBool(g_CVarEnabled))
    { 
        if (FileExists(file)) 
        { 
            ServerCommand("exec %s", file);
        } 
        else
        { 
            ServerCommand("exec round_exec/round_start.cfg"); 
        } 
    }

The round end one has the same problem.

[Powerlord]

Err... I also just noticed that you never set file to a value. So FileExists against it is always going to fail.

Edit: I've edited my previous post to account for that, although it has no security precautions for said file (i.e. checking for . or ..)

[valio_skull]

Originally Posted by Powerlord Err... I also just noticed that you never set file to a value. So FileExists against it is always going to fail. Edit: I've edited my previous post to account for that, although it has no security precautions for said file (i.e. checking for . or ..)

Same thing. It execs both of the cfg files. I want just one of them.
If I'm on de_dust2 and and de_dust2_start.cfg it's present I want just it to be executed
and if isn't present, to execute round_start.cfg
Same with de_dust2_end and round_end cfg.

[jess]

You need to BuildPath using Path_SM for proper file location if you're going to be using !FileExists , here this is what I do in my rpg plugin:

BuildPath(Path_SM, cfgPath, sizeof(cfgPath), "configs/");
    Format(cfgPathEx, sizeof(cfgPathEx), "%s%s", cfgPath, CONFIG_MAIN);
    ClearArray(Handle:a_MainMenu);
    if (!ParseConfigFile(cfgPathEx)) SetFailState("%s Improperly formatted.", cfgPathEx);
    Format(cfgPathEx, sizeof(cfgPathEx), "%s%s", cfgPath, CONFIG_POINTS);
    ClearArray(Handle:a_Points);

It's not the exact same thing you're doing, but similarly, instead of using ParseConfigFile, use if (FileExists(cfgPathEx)) { //do }

[Powerlord]

Originally Posted by jess You need to BuildPath using Path_SM for proper file location if you're going to be using !FileExists , here this is what I do in my rpg plugin: BuildPath(Path_SM, cfgPath, sizeof(cfgPath), "configs/"); Format(cfgPathEx, sizeof(cfgPathEx), "%s%s", cfgPath, CONFIG_MAIN); ClearArray(Handle:a_MainMenu); if (!ParseConfigFile(cfgPathEx)) SetFailState("%s Improperly formatted.", cfgPathEx); Format(cfgPathEx, sizeof(cfgPathEx), "%s%s", cfgPath, CONFIG_POINTS); ClearArray(Handle:a_Points); It's not the exact same thing you're doing, but similarly, instead of using ParseConfigFile, use if (FileExists(cfgPathEx)) { //do }

If you want a file in one of SourceMod's folders you need BuildPath. However, the game uses its base directory for relative paths.

What's more, exec looks in cfg/ by default, which is why on a TF2 server, I can¹ exec replay.cfg which is really the file tf/cfg/replay.cfg

¹Note that I said can, not should. If you want to have replay enabled on a server, the -replay command line option is the best way to do it as it auto-adjusts the slot count.