[olj]

Ok, this code deletes medkits on every round start around first found survivor in 800 radius. However one of my comrades reported about this plugin removing medkits near FINALE RADIOS! Can someone check it for logical mistakes maybe im doing something wrong...?

I think this can be somehow related to events firing sequence in finales or something like that. Any help appreciated.

PHP Code:


new Float:vOrigin[MAXPLAYERS+1][3];
new bool:Found = false;
new Handle:MedkitsTimer[1];
new Handle:hMedkitsTime;

public OnPluginStart()
    {
        HookEvent("round_start", EventMEDS, EventHookMode_Post);
        HookEvent("round_end", EventRoundEnd, EventHookMode_Pre);
        hMedkitsTime = CreateConVar("l4d_medkits_time", "24.0", "Time before we give medkits", CVAR_FLAGS);
    }
    
public Action:EventMEDS(Handle:event, const String:name[], bool:dontBroadcast)
    {
        MedkitsTimer[0] = CreateTimer(1.0, TimerDelay, _, TIMER_FLAG_NO_MAPCHANGE|TIMER_REPEAT);
        new Flags = GetCommandFlags("give");
        CreateTimer(GetConVarFloat(hMedkitsTime), GiveMedkitsTimer, any:Flags, TIMER_FLAG_NO_MAPCHANGE);
    }

public Action:EventRoundEnd(Handle:event, const String:name[], bool:dontBroadcast)
    {
        Found = false;
    }
    
public Action:TimerDelay(Handle:timer)
    {
        if (Found)
            {
                MedkitsTimer[0] = INVALID_HANDLE;
                return Plugin_Stop;
            }
        
        new Float:FirstSurvivorOrigin[3];
                for (new i=1;i<MaxClients;i++)
                    {
                        if (IsValidClient(i))
                            {
                                // decl String:Name[MAX_NAME_LENGTH];
                                // GetClientName(i, Name, MAX_NAME_LENGTH);
                                GetClientAbsOrigin(i,vOrigin[i]);
                                FirstSurvivorOrigin = vOrigin[i];
                                Found = true;
                                break;
                            }
                    }

        new ent = -1;
        while ((ent = FindEntityByClassname2(ent, "weapon_first_aid_kit_spawn")) != -1)
            {
                        new Float:MEDlocation[3];
                        GetEntPropVector(ent, Prop_Send, "m_vecOrigin", MEDlocation);
                        new Distance = RoundToNearest(GetVectorDistance(FirstSurvivorOrigin, MEDlocation, false));
                        if (Distance<800)
                            {
                                RemoveEdict(ent);
                            }
            }
        return Plugin_Continue;
    }

public Action:GiveMedkitsTimer(Handle:timer, any:Flags)
    {
        for (new i = 1; i <=MaxClients; i++)
            {
                if ((IsClientInGame(i))&&(IsPlayerAlive(i))&&(GetClientTeam(i)==2)&&(i>0)) ExecuteCommand(i, "give", "first_aid_kit");
                if (i==MaxClients)
                    {
                        SetCommandFlags("give", Flags);
                    }
            }
    }    
    
stock FindEntityByClassname2(startEnt, const String:classname[])
{
/* If startEnt isn't valid shifting it back to the nearest valid one */
while (startEnt > -1 && !IsValidEntity(startEnt)) startEnt--;
return FindEntityByClassname(startEnt, classname);
}
    
ExecuteCommand(Client, String:strCommand[], String:strParam1[])
{
    if (Client==0) return;
    new Flags = GetCommandFlags(strCommand);
    SetCommandFlags(strCommand, Flags & ~FCVAR_CHEAT);
    FakeClientCommand(Client, "%s %s", strCommand, strParam1);
}
        
public IsValidClient(client)
{
    if (client == 0)
        return false;
    
    if (!IsClientConnected(client))
        return false;
    
    //if (IsFakeClient(client))
        //return false;
    
    if (!IsClientInGame(client))
        return false;
    
    if (!IsPlayerAlive(client))
        return false;
        
    if (GetClientTeam(client)!=2)
        return false;
    return true;
} 


[Frus]

I am using the distance from "prop_door_rotating_checkpoint" (i.e. safe room door) to determine safe room medkits in finales for one of my plugins.

Anyways, could I inquire why you made a plugin to remove kits on the ground and give them directly to the survivors?

[Flynn]

Originally Posted by olj Ok, this code deletes medkits on every round start around first found survivor in 800 radius.

You could run at the very least a standard debugging approach by printing out the two vectors and the given distance to figure out why.

Your uh, entity code is what I'd call 'highly bastardised' (incredibly confusing - the more so, the more likely there are to be bugs in it).

Just to pick out some peices...

new ent = -1;
    while ((ent = FindEntityByClassname2(ent, "weapon_first_aid_kit_spawn")) != -1)

stock FindEntityByClassname2(startEnt, const String:classname[])
{
/* If startEnt isn't valid shifting it back to the nearest valid one */
while (startEnt > -1 && !IsValidEntity(startEnt)) startEnt--;
return FindEntityByClassname(startEnt, classname);
}

Bastardised parts highlighted. You're starting from -1, with a loop that breaks out on -1 (with a deincrementation operation), and returns ??? because FindEntity is given -1;

A better question is why is your code even able to remove medkits?

Edit: I presume FindEntity starts from -1, counts up, returns the first entity, the loop deincrements it back down, and because FindEntity only returns -1 when it -cannot find any more medkits- it gets trapped in an infinite loop until every single one is removed (which, when the player arrives at the finale spot, gets removed because the operation is still continuously operating - because there are still kits out there).

In short; Assumption and Presumption fail.

Originally Posted by SourceMod Documentation Return: Entity index >= 0 if found, -1 otherwise.

[Flynn]

As for the solution, you should not try to use hacky hacky cody buggy idea, but instead find the maximum number of entities and do a single pass (incrementing upwards) until your entity number is either equal to or exceeds the maximum.

Heading in the other direction won't work. Not with FindEntityByClassname anyway.

Remember Kids; lazy coding costs time!

Edit: Also, I don't recommend Copy Pasta.

exvelSeptember 2, 2009, 5:55 amI've just replaced this function with my own that automatically checks if start entity is valid and if not just shifts to the nearest valid one: 1: stock FindEntityByClassname2(startEnt, const String:classname[]) 2: { 3: /* If startEnt isn't valid shifting it back to the nearest valid one */ 4: while (startEnt > -1 && !IsValidEntity(startEnt)) startEnt--; 5: 6: return FindEntityByClassname(startEnt, classname); 7: }

[MockingBird]

Originally Posted by Flynn You could run at the very least a standard debugging approach by printing out the two vectors and the given distance to figure out why. Your uh, entity code is what I'd call 'highly bastardised' (incredibly confusing - the more so, the more likely there are to be bugs in it). Just to pick out some peices... new ent = -1; while ((ent = FindEntityByClassname2(ent, "weapon_first_aid_kit_spawn")) != -1) stock FindEntityByClassname2(startEnt, const String:classname[]) { /* If startEnt isn't valid shifting it back to the nearest valid one */ while (startEnt > -1 && !IsValidEntity(startEnt)) startEnt--; return FindEntityByClassname(startEnt, classname); } Bastardised parts highlighted. You're starting from -1, with a loop that breaks out on -1 (with a deincrementation operation), and returns ??? because FindEntity is given -1; A better question is why is your code even able to remove medkits? Edit: I presume FindEntity starts from -1, counts up, returns the first entity, the loop deincrements it back down, and because FindEntity only returns -1 when it -cannot find any more medkits- it gets trapped in an infinite loop until every single one is removed (which, when the player arrives at the finale spot, gets removed because the operation is still continuously operating - because there are still kits out there). In short; Assumption and Presumption fail.

That code is fine. 'ent' is initted to -1 because the FindEntityByClassname looks for entities PAST the index given. If you want to start at 0, the index needs to be -1. The new entity found is then past into the 'ent' variable making it no longer equal to -1, and hence making the boolean expression true. Then after the loop, that new ent is then passed into the FindEntity function, and it starts again. The FindEntity function will return -1 when no entity is found, exitting the loop.

If no entity is found, the ent value will then be equal to -1, which is why his next code checks for the ent value to be greater than -1 so that it wont operate on a none existant entity.

I use this loop allot, and it works fine for me. I dont play L4D, so I cant help you with your actual problem xD

[olj]

Originally Posted by Frus I am using the distance from "prop_door_rotating_checkpoint" (i.e. safe room door) to determine safe room medkits in finales for one of my plugins. Anyways, could I inquire why you made a plugin to remove kits on the ground and give them directly to the survivors?

Just a request from l4d-support.ru

[olj]

To Flynn - the code works fine,except for finals, and that happens not all times, judging from what i've been told by reqester. And I actually trust Exvel in whats he doing with this stock function. And i dont want to loop through incredible amount of entities on the map, especially if i want only 4 of them. Copy pasting is fine, you dont want to invent a wheel, because its already invented. You haven't provided any help, except for some mysterious "DONT USE HACKY FUNCTIONS", lol, i know what I'm doing usually. And If I dont, I browse scripting forums and development section to find answers and adjust code untill it works.

[Dragonshadow]

Whereas I have no clue what I'm doing half the time and thus have to ask everyone for help!

/humor

[AtomicStryker]

Your mistake is fairly obvious to me. All you do is check for medkits around an 800 radius of the survivor (which is a lot). This would naturally delete the medkits on No Mercy Finale, being just above the starting safe room.


As an alternative you should just delete the 4 meds closest to the Survivors ^^

[Flynn]

Originally Posted by olj And I actually trust Exvel in whats he doing with this stock function. And i dont want to loop through incredible amount of entities on the map, especially if i want only 4 of them. Copy pasting is fine, you dont want to invent a wheel, because its already invented. You haven't provided any help, except for some mysterious "DONT USE HACKY FUNCTIONS", lol, i know what I'm doing usually. And If I dont, I browse scripting forums and development section to find answers and adjust code untill it works.

I never said anything was wrong with his functions. Although you are using his function for a purpose not intended - it's designed to find the first instance of a given entity starting from -1 for a single usage, not for a while loop that only breaks out when -1 is returned.

In short, his function works by rewinding back to -1 when it receives a higher than -1 number and whilst those numbers are valid entities, and FindEntityByClassname returns the entity index of the given class (or -1 if it doesn't find any). The point is, your loop only breaks out when it cannot find any more medkits, except, because the stock function 'rewinds' back to the start, it will always find medkits.

For example, if I have only three entities, 0 is the spawn point, 1 is a medkit that is nearby, and 2 is a medkit is far away, and it keeps restarting from 0 and removes 1 (but is still searching for valid medkits) and 2 is a valid medkit - it's going to keep returning 2 until 2 is removed, if you catch my drift.

I would take the liberty of testing that specific code, but I'm going to have to be content with people believing the mathematical distance to be at fault and wondering why the problem still exists even after reducing it (FYI 800 is a relatively 'small' distance, in ZPS 500 would heal zombies within a '4 man' radius).

I would have suspected distance but a lot of the finales in the standard campaigns are a good distance away.