[QOOOOOOOOQ]

PHP Code:

public Action:EC_Command_LockConvar(iClient, iArgs)
{
    /*
     *    Get all the command information in one lump sum, along with making sure the command was given correct params.
     */
    decl String:sConVarActions[8];
    GetCmdArg(1, sConVarActions, sizeof(sConVarActions));
    decl String:sConVar[32];
    GetCmdArg(2, sConVar, sizeof(sConVar));
    decl String:sValue[32];
    GetCmdArg(3, sValue, sizeof(sValue));

    /*
     *    Make sure the command is actually valid before commiting to any actions hereafter.
     */
    new Handle:hConVar = FindConVar(sConVar);
    if(hConVar == INVALID_HANDLE)
        return Plugin_Handled;

    /*
     *    We must first check if the convar is already in the trie before we possibly add multiple HookConVarChange
     *        functions in a row (todo).
     */
    HookConVarChange(hConVar, EC_ConVarChanged_GenericConVar);

    if(IsClientAndInGame(iClient)) Client_PrintToConsole(iClient, "[SC] The convar '%s' is now hooked.", sConVar);
}

public EC_ConVarChanged_GenericConVar(Handle:hConvar, const String:sOldValue[], const String:sNewValue[])
{
    /*
     *    No need for checks, sOldValue and sNewValue are guaranteed to be different.
     */
    SetConVarString(hConvar, sOldValue);

} 


No errors logged within SourceMod logs, so I can only assume this is what is causing it. It 'hooks' fine, but when I use sm_cvar to change the command, server instantly goes down if it's 'hooked'.

[ddhoward]

1. cvar is set to "butts"
2. cvar gets hooked
3. someone sets it to "lolno"
4. the hook causes it to be set to it's old value, "butts"
5. the cvar has been changed, to "butts". the hook causes it to be reset to its old value of "lolno"
6. the cvar has been changed, to "lolno". the hook causes it to be reset to its old value of "butts"
7. the cvar has been changed, to "butts". the hook causes it to be reset to its old value of "lolno"
8. repeat this infinite loop over and over

[QOOOOOOOOQ]

Damn, completely forgot about that, looks like I'll have to look up the trie value string for the convar, then check for consistency before I alter the convar then. Thanks. (Storing the convar value when it's 'locked' and placing into a trie should prove efficient, I think.)

[Dr. Greg House]

damn those lolnoes and butts

[asherkin]

Originally Posted by QOOOOOOOOQ Damn, completely forgot about that, looks like I'll have to look up the trie value string for the convar, then check for consistency before I alter the convar then. Thanks. (Storing the convar value when it's 'locked' and placing into a trie should prove efficient, I think.)

Welcome to the wonders of a single-threaded execution environment.

public EC_ConVarChanged_GenericConVar(Handle:hConvar, const String:sOldValue[], const String:sNewValue[])
{
    static bool:inHook = false;
    if (inHook) return;
    inHook = true;
    SetConVarString(hConvar, sOldValue);
    inHook = false;
}