[.Dare Devil.]

Hi,

I have problem.

PHP Code:

 
public fw_PlayerKilled(victim, attacker, shouldgib)
{
 
     if (get_pcvar_num(cvar_nemfraggore))
     {
          if (g_assassin[attacker]) // This is 2406
         {
                 SetHamParamInteger(3, 2)
         }
     }
} 


And the error logs show me :

L 10/21/2011 - 10:25:23: [AMXX] Displaying debug trace (plugin "DarkAngels.amxx") L 10/21/2011 - 10:25:23: [AMXX] Run time error 4: index out of bounds L 10/21/2011 - 10:25:23: [AMXX] [0] DarkAngels.sma::fw_PlayerKilled (line 2406)

What i did wrong here?

Is a Attacker Index invalid number?
should i check this

Is_connected
Is_valid_id
is_alive

Idk know anymore, i have try to do it but it is not helping.

When i have add this, one week this was okey ( no error logs )
But now, this line spam a error logs.


Mayby error come when player killed by gravity or something

[r0ck]

if(!is_user_connected(attacker))
return HAM_IGNORED

[Stereo]

And check if the attacker is valid player:

PHP Code:

public fw_PlayerKilled(victim, attacker, shouldgib)
{
    if (get_pcvar_num(cvar_nemfraggore))
    {
        if (g_assassin[attacker] && is_user_connected(attacker) && 1 <= attacker <= get_maxplayers()) // This is 2406
        {
            SetHamParamInteger(3, 2)
        }
    }
} 


[Bugsy]

is_user_connected() takes care of that, you don't need both.

[r0ck]

ya

[Bugsy]

You need to put the is_user_connected check first though because the error can/will happen in the array (where the error occurred in first post) before the connected check is done. If the connected check fails, the execution will not hit the array.

PHP Code:

public fw_PlayerKilled(victim, attacker, shouldgib)
{
    if (get_pcvar_num(cvar_nemfraggore))
    {
        if (is_user_connected(attacker) && g_assassin[attacker]) // This is 2406
        {
            SetHamParamInteger(3, 2)
        }
    }
}