error 036: empty statement

ish12321 · **Author**

PHP Code:


			
    switch (get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE]))
    {
        case 1: // SteamID
        {
            get_user_authid(id, saveby, charsmax(saveby));
            if(get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE_SECONDARY]) && ((equali(saveby, "STEAM_ID_LAN")) || (equali(saveby, "VALVE_ID_LAN"))));
            {
                get_user_name(id, saveby, charsmax(saveby));
            }
        }
        case 2: // Name
        {
            get_user_name(id, saveby, charsmax(saveby));
        }
    }

klippy · 11-03-2016 , 03:26 Re: error 036: empty statement

You put a semicolon after the IF statement.

siriusmd99 · 11-03-2016 , 09:18 Re: error 036: empty statement

Quote:

Originally Posted by ish12321

PHP Code:


			
    switch (get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE]))
    {
        case 1: // SteamID
        {
            get_user_authid(id, saveby, charsmax(saveby));
            if(get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE_SECONDARY]) && ((equali(saveby, "STEAM_ID_LAN")) || (equali(saveby, "VALVE_ID_LAN"))));
            {
                get_user_name(id, saveby, charsmax(saveby));
            }
        }
        case 2: // Name
        {
            get_user_name(id, saveby, charsmax(saveby));
        }
    }

Also you can optimize it and not use switch.

You can directly check for case 1 and add the rest of your condition.
Like this:

PHP Code:


			
if(get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE]) == 1 && !get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE_SECONDARY]) && !equali(saveby, "STEAM_ID_LAN") && !equali(saveby, "VALVE_ID_LAN"));
{
    get_user_authid(id, saveby, charsmax(saveby));
}
else
{
    get_user_name(id, saveby, charsmax(saveby));
}

Napoleon_be · 11-03-2016 , 10:03 Re: error 036: empty statement

I think readability is still more important than optimizing something like that...

ish12321 · 11-03-2016 , 11:34 Re: error 036: empty statement

Quote:

Originally Posted by siriusmd99

Also you can optimize it and not use switch.

You can directly check for case 1 and add the rest of your condition.
Like this:

PHP Code:


			
if(get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE]) == 1 && !get_pcvar_num(g_Pcvar[CVAR_WC3_G_SAVE_MODE_SECONDARY]) && !equali(saveby, "STEAM_ID_LAN") && !equali(saveby, "VALVE_ID_LAN"));

{

    get_user_authid(id, saveby, charsmax(saveby));

}

else

{

    get_user_name(id, saveby, charsmax(saveby));

}

I'm soon gonna add another case to it