[xines]

Hello i'm having some problems with "SDKHooks_TakeDamage" causing my script to somehow multiply on player_hurt, this have a impact on PrintToChat and the damage being sent sometimes 1-4 times at one shot, including the PrintToChat?

Please help o.o

PHP Code:

public OnPluginStart()
{
    HookEvent("player_hurt", OnPlayerHurt, EventHookMode_Post);
}

public Action:OnPlayerHurt(Handle:event, const String:name[], bool:dontBroadcast)
{
    new victim = GetClientOfUserId(GetEventInt(event, "userid"));
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    if( victim == attacker ) // if self damage
    {
        return Plugin_Handled;
    }
    else 
    {
        new rand = GetRandomInt(1, 100);
        new chance = 30;
        if (rand <= chance)
        {
            doclaw(attacker, victim);
        }
    }
    return Plugin_Continue;
}

doclaw(client, target)
{
    if (IsClientInGame(client) && IsClientInGame(target) && IsPlayerAlive(client) && IsPlayerAlive(target) && GetClientTeam(target) != GetClientTeam(client))
    {
        SDKHooks_TakeDamage(target, client, client, 6.0, DMG_BULLET, -1, NULL_VECTOR, NULL_VECTOR); //stupid shit causing doubles
        PrintToChat(attacker, "\x04[Claws]\x03 did 6+ dmg");
    }
} 


[WildCard65]

I think the game is causing the event to fire when you call SDKHooks_TakeDamage

[xines]

So i would need another damage method you think?

[Pelipoika]

Originally Posted by xines So i would need another damage method you think?

Use the OnTakeDamage SDKHook https://sm.alliedmods.net/new-api/sdkhooks/SDKHookCB SDKHooks_TakeDamage doesn't trigger it

[thecount]

You could have a boolean value per player that helps stop the loop. Also, you could avoid the two variables for your chance.

Spoiler

PHP Code:

new bool:claw[MAXPLAYERS + 1];

public OnPluginStart() 
{ 
    HookEvent("player_hurt", OnPlayerHurt, EventHookMode_Post); 
} 

public Action:OnPlayerHurt(Handle:event, const String:name[], bool:dontBroadcast) 
{ 
    new victim = GetClientOfUserId(GetEventInt(event, "userid")); 
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker")); 
    if( victim == attacker ) // if self damage 
    { 
        return Plugin_Handled; 
    } 
    else  
    { 
        if(!claw[attacker])
        {
            if (GetRandomInt(1,10) <= 3) 
            { 
                doclaw(attacker, victim); 
            }
        }else{
            claw[attacker] = false;
        }
    } 
    return Plugin_Continue; 
} 

doclaw(client, target) 
{ 
    if (IsClientInGame(client) && IsClientInGame(target) && IsPlayerAlive(client) && IsPlayerAlive(target) && GetClientTeam(target) != GetClientTeam(client)) 
    {
        claw[attacker] = true;
        SDKHooks_TakeDamage(target, client, client, 6.0, DMG_BULLET, -1, NULL_VECTOR, NULL_VECTOR); //stupid shit causing doubles 
        PrintToChat(attacker, "\x04[Claws]\x03 did 6+ dmg"); 
    } 
} 


[xines]

Okay i tried the "OnTakeDamage", it seemed to remove the doubles with the print and stuff, but it wont seem to damage at all, maybe i did something wrong?

- Thecount, im using this in a shop function where u can buy the claws, so i already have added a way to prevent it from being fired to everyone but thanks, added it into the code so you could see

PHP Code:

public Action:OnPlayerHurt(Handle:event, const String:name[], bool:dontBroadcast)
{
    new victim = GetClientOfUserId(GetEventInt(event, "userid"));
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    if( victim == attacker ) // if self damage
    {
        return Plugin_Handled;
    }
    if (Clawsatk_uses[attacker] == 1)
    {
        if (GetRandomInt(1,10) <= 3)
        {
            //doclaw(attacker, victim);
            SDKHook(attacker, SDKHook_OnTakeDamage, OnTakeDamage);
            PrintToChat(attacker, "\x04[Claws]\x03 did 6+ dmg");
        }
    }
    return Plugin_Continue;
}


public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype)
{
    if (IsClientInGame(attacker) && IsClientInGame(victim) && IsPlayerAlive(attacker) && IsPlayerAlive(victim) && GetClientTeam(victim) != GetClientTeam(attacker))
    {
        SDKHooks_TakeDamage(victim, attacker, attacker, 6.0, DMG_BULLET, -1, NULL_VECTOR, NULL_VECTOR);
    }
}

/*
doclaw(client, target)
{
    if (IsClientInGame(client) && IsClientInGame(target) && IsPlayerAlive(client) && IsPlayerAlive(target) && GetClientTeam(target) != GetClientTeam(client))
    {
        //ServerCommand("wcs_xdealdamage %i %i 6", client, target);
        SDKHooks_TakeDamage(target, client, client, 6.0, DMG_BULLET, -1, NULL_VECTOR, NULL_VECTOR); //stupid shit causing doublezzz
    }
}
*/ 


[WildCard65]

OnTakeDamage is called when the game needs to deal damage to an entity. The event is triggered after the damage is dealt(Which is too late for OnTakeDamage to catch it)

[Pelipoika]

PHP Code:

public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype) 
{ 
    if (victim != attacker && Clawsatk_uses[attacker] == 1) 
    {
        if (GetRandomInt(1, 10) <= 3 && IsClientInGame(attacker) && IsClientInGame(victim) && IsPlayerAlive(attacker) && IsPlayerAlive(victim) && GetClientTeam(victim) != GetClientTeam(attacker))
        { 
            //doclaw(attacker, victim); 
            //SDKHook(attacker, SDKHook_OnTakeDamage, OnTakeDamage); //Move this into OnClientConnected or smthn
            SDKHooks_TakeDamage(victim, attacker, attacker, 6.0, DMG_BULLET, -1, NULL_VECTOR, NULL_VECTOR); 
            PrintToChat(attacker, "\x04[Claws]\x03 did 6+ dmg"); 
        }
    }
    
    return Plugin_Continue; 
} 


Something like that

[Dr. Greg House]

Originally Posted by Pelipoika Use the OnTakeDamage SDKHook https://sm.alliedmods.net/new-api/sdkhooks/SDKHookCB SDKHooks_TakeDamage doesn't trigger it

I'm seeing this the second time now.
The hook not firing is not intended, it's actually a bug. I know that because I have been asking about this a while ago. Please do not advise people to rely on this. I would love to see get this fixed in 2-3 years instead of someone then saying "well it will break a lot of plugins".

[WildCard65]

Originally Posted by Dr. Greg House I'm seeing this the second time now. The hook not firing is not intended, it's actually a bug. I know that because I have been asking about this a while ago. Please do not advise people to rely on this. I would love to see get this fixed in 2-3 years instead of someone then saying "well it will break a lot of plugins".

I'm pretty sure SDKHook_TakeDamage bypassing the OnTakeDamage hook is intended.