[XAT]

Since none answeared my last question, i've made some progress by myselfe and i got another question.

How does set_task works with a 0.0 time, as i understand it should immediately call the function behind it but somehow it makes difference when i use it. Ex. Ham_Item_AddToPlayer hook, when i change player offsets in this hook (pre or post, dosen't make a difference) it is overwited (by game function ? cs_i386 ?), but when i use this immediately task in the same hook, it isn't overwrited anymore.

So how does this thing work ? Does task have extra seconds or something ? Or does anyone know in what function after this hook can i safety set this (weapon / item) offsets without this laggy timer ?

[Arkshine]

set_task with 0.0 doesn't make sense to start. The minimal time is 0.1, if you put 0.0, it will be considered to 0.1.
Instead of focusing on set_task, you should try to understand what you're doing about the offsets you want to set. What offsets are you talking about ? If offsets are overwritten whatever pre/post and it works after 0.1s, it would mean AddToPlayer is inappropriate.

[Doc-Holiday]

You should be able to set any offset in pre from what i understand it just depends on your return after you set it.

[XAT]

What am i trying to do is change offset 42 (m_pNext) when Ham_Item_AddToPlayer (or player gets a new weapon) is called

It works with a task but i found it laggy as Arkshine said its 0.1 and sometimes its annoying.

[Arkshine]

You should try to learn working with HLSDK.

PHP Code:

BOOL CBasePlayer::AddPlayerItem( CBasePlayerItem *pItem )
{
    CBasePlayerItem *pInsert;

    pInsert = m_rgpPlayerItems[ pItem->iItemSlot() ];

    while( pInsert )
    {
        if( FClassnameIs( pInsert->pev, STRING( pItem->pev->classname ) ) )
        {
            if( pItem->AddDuplicate( pInsert ) )
            {
                g_pGameRules->PlayerGotWeapon( this, pItem );
                pItem->CheckRespawn();

                // ugly hack to update clip w/o an update clip message
                pInsert->UpdateItemInfo( );

                if( m_pActiveItem )
                    m_pActiveItem->UpdateItemInfo();

                pItem->Kill( );
            }
            else if( gEvilImpulse101 )
            {
                // FIXME: remove anyway for deathmatch testing
                pItem->Kill();
            }
            return FALSE;
        }

        pInsert = pInsert->m_pNext;
    }


    if( pItem->AddToPlayer( this ) )
    {
        g_pGameRules->PlayerGotWeapon( this, pItem );

        if( pItem->iItemSlot() == ItemSlot_Primary )
        {
            m_fHasPrimaryWeapon = TRUE;
        }

        pItem->CheckRespawn();

        pItem->m_pNext = m_rgpPlayerItems[ pItem->iItemSlot() ];
        m_rgpPlayerItems [pItem->iItemSlot() ] = pItem;

        if( HasShield() )
        {
            pev->gamestate = 0;
        }

        // should we switch to this item?
        if( g_pGameRules->FShouldSwitchWeapon( this, pItem ) && !IsProtectedByShield() )
        {
            SwitchWeapon( pItem );
        }

        return TRUE;
    }
    else if( gEvilImpulse101 )
    {
        // FIXME: remove anyway for deathmatch testing
        pItem->Kill();
    }
    return FALSE;
} 


AddToPlayer is called inside AddPlayerItem and you see m_pNext is set after AddToPlayer, so of course whatever pre/post, that's not going to work. Here, you should hook AddPlayerItem as post, check return is 1, then setting the offset.

[XAT]

Well, i've done what you've said but i get strange error after i set the offset. It seems to be set (message shows after set_pdata_cbase) but i get crash.

PHP Code:

0xb5655f5e in CWeaponBox::Touch(CBaseEntity *) () 


Any ideas what am i doing wrong ?

[Arkshine]

Nobody can help you if you don't explain exactly what you want really to do, and what you have done exactly if there is a problem.

[XAT]

Originally Posted by Arkshine Nobody can help you if you don't explain exactly what you want really to do, and what you have done exactly if there is a problem.

I'm trying to extend player primary and secondary weapon slots.
I want to make them holding multiple primary/secondary weapons.
i've got it working ExecuteHam(Ham_AddPlayerItem, ...) in touch forward, but when i drop weapons fast and pick up them in same time i get random crashes.

PHP Code:

Program received signal SIGINT, Interrupt.
0xb5655f60 in CWeaponBox::Touch(CBaseEntity *) ()
   from /home/hlds/cstrike/dlls/cs_i386.so
(gdb) bt
#0  0xb5655f60 in CWeaponBox::Touch(CBaseEntity *) ()
   from /home/hlds/cstrike/dlls/cs_i386.so
#1  0xb50bfb8c in Hook_Void_Cbase (hook=0x8f07da8, pthis=0x8fd3cb0,
    other=0x8fcf4c8) at hook_callbacks.cpp:256
#2  0x08f08016 in ?? ()
#3  0xb55d5f21 in DispatchTouch(edict_s *, edict_s *) ()
   from /home/hlds/cstrike/dlls/cs_i386.so
#4  0xb58198fb in mm_DispatchTouch(edict_s *, edict_s *) ()
   from ./cstrike/addons/metamod/dlls/metamod_i386.so
#5  0xb5bc1c48 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb) cmd_args
$9 = 0x0 


It seems to be invalid entity or not assigned yet, is this a reason of the crash ? Too fast weapon drop and pick ?

[XAT]

I've found the problem, i used ExecuteHam in touch forward pre so too many calls caused crash...

Solved, thanks Arkshine.

[Arkshine]

So you have done what exactly ?

I've fastly looked, to allow to get multiple weapons by touching a weaponbox entity, one solution would be to hook Touch as pre, saving entity from m_rgpPlayerItems (player offset) of the touched item's slot, replacing by 0 so it will allow to add a new weapon. Then, hooking AddPlayerItem as pre and restoring the entity.