[spamipolito]

Hi guys. I wanted to know if this way of obtaining rank can cause server lag. Sorry for my english :c

PHP Code:

public clcmd__Rank(id)
{                    
    static iData[1] 
     
    formatex(g_szQuery, charsmax( g_szQuery ), "SELECT * FROM %s ORDER BY `Level` DESC, `KILLS` DESC", szTableData) 

    iData[0] = id 
    mysql_query(g_Connection, "rankMe", g_szQuery, iData, 1) 
} 

public rankMe(failstate, error[], errnum, data[], size, Float:queuetime) {  
    if(failstate == TQUERY_CONNECT_FAILED || failstate == TQUERY_QUERY_FAILED) {  
        log_to_file( "SQL_LOG_TQ.txt", "Error en la consulta al MySQL [%i]: %s", errnum, error );
        return 
    } 
    else { 
        static id; id = data[0]

        if(mysql_num_results())
        { 
            static Count, Character[33]

            Count = 0
             
            WPN_MAXTOP = mysql_num_results()
             
            for(new i = 0;i < Count;i++)
                mysql_next_row()
             
            while(mysql_more_results())
            { 
                if(Count < WPN_MAXTOP)
                {             
                    mysql_read_result(mysql_fieldnametonum("Character"), Character, 32)
                    
                    if (equal(Character, g_playername[id]))
                    {
                        colorChat(id, _, "!g[%s]!y Rank position:!g %d / %d", COMMUNITY, Count+1, WPN_MAXTOP)
                        mysql_next_row()
                        break;
                    }
                    
                    Count++ 
                         
                    mysql_next_row() 

                } 
                else 
                    break; 
            }
        }
    } 
} 


[Bugsy]

Use threaded queries: https://forums.alliedmods.net/showthread.php?t=46779

[+ARUKARI-]

Use the AuthID as a key to narrow down the results to one.

[Bugsy]

Oh, I didn't even look at the SQL, lol. Put as much filtering criteria as possible.

[spamipolito]

Solution:

PHP Code:

public clcmd__Rank(const id)
{ 
    static iData[1];
    formatex(g_szQuery, charsmax( g_szQuery ), "select * from ( select T.*,(@rownum := @rownum + 1) as posicion from ( select * from %s group by PJ_ID order by Level DESC, KILLS DESC ) as T JOIN (SELECT @rownum := 0) r ) as w where PJ_ID = ^"%d^"", szTableData, g_CharacterID[id]);

    iData[0] = id;
    mysql_query(g_Connection, "show__Rank", g_szQuery, iData, 1);
}

public show__Rank(failstate, error[], errnum, data[], size, Float:queuetime)  
{  
    if(failstate == TQUERY_CONNECT_FAILED || failstate == TQUERY_QUERY_FAILED)  
    {  
        log_to_file( "SQL_LOG_TQ.txt", "Error en la consulta al MySQL [%i]: %s", errnum, error );
        return;
    }
    else
    {
        new id = data[0]

        g__RankPosition[id] = mysql_read_result(mysql_fieldnametonum("posicion"))    

        colorChat(id, _, "!g[%s]!y Rank position #%i / #%d", COMMUNITY, g__RankPosition[id], g__GlobalTotalCharacters)
    }
} 


[+ARUKARI-]

Show us the table layout.
The id changes when the player is connected timing.
Use the SteamID that you can get with get_user_authid.

[spamipolito]

Originally Posted by +ARUKARI- Show us the table layout. The id changes when the player is connected timing. Use the SteamID that you can get with get_user_authid.

I use account system with multiple characters. Example: Account "Covid19" Characters: ("William", "Robert", "Analisa Melchoto", etc..).

[Bugsy]

Add a field for steam id and use that to identify players.

[spamipolito]

Originally Posted by Bugsy Add a field for steam id and use that to identify players.

Don't use accounts?
UserID (Account) change to UserID = SteamID ?

[Bugsy]

Yeah, the field name doesn't matter.