[Chrisber]

Hi.
Currently I've a problem when unloading as an VSP plugin (MM:S works perfectly).
This happens both times, unloading via plugin_unload or just quitting the server.

Scenario #1: quitting the server

quit
# nothing happens for 5 seconds
<error messagebox>

Scenario #2: plugin_unload

plugin_unload 0
# nothing happens now, seems to work fine
# typing anything to console and pressing enter
# wait 5 seconds
<error messagebox>

Does anybody know why this happens? I can't believe that my plugin causes this because the MM:S binary works fine.
For debugging, I've put a message in the Unload()-function. It is printed out.

Thanks for any help!

[BAILOPAN]

AFAIK vsps are not designed to be unloaded. Last time I used one (though that was 2005) the server didn't even close the library.

[Keeper]

They can be unloaded, but for some reason it's not clean like MMS. I've never been able to do it either, but I've never really tried.

Have you tried to remove your CVARs before unloading? Look at the way MMS unloads and try to do some of the same things to see what happens.

[Chrisber]

Hi.
@ BAIL: On EP1 it worked without any problems, OB and higher doesn't seem to work.
@ Keeper: Tried. Also tried to completly remove the BaseAccessor for ConCommands and ConVars, didn't change anything.

Maybe I need to add "extra" code calls for SourceHook to say it that my plugin (and so ofcourse the instance of SH) will shut down?
But currently I've no hooks active in the VSP version.

Thanks!

[J3Di]

Sounds a bit like an interesting problem I've just come up against.

I hook ConCommand::Dispatch using SourceHook and when Unload() is called it appears to remove the hook successfully but it has actually crashed. A little while later you get the old message:
"File: .\workthreadpool.cpp
Line: 296
Assertion: Assertion Failed: CWorkThreadPool::StopWorkThreads: Some threads required forcible termination."

I've tested this from a basic shell plugin, just the VALVe plugin sample + SourceHook - Add Hook to ConCommand::Dispatch on Load() then use the console command "plugin_unload 0" to remove the plugin and it happens every time the ConCommand is hooked. Watching the ConCommand interface ptr in the debugger and that's fine.

I understand since the Orange Box update they call delete on your plugin's interface, which unless I hook a ConCommand's Dispatch method occurs cleanly but are VALVe forcibly ejecting your entire module or something and therefore SourceHook?
I haven't had a lot of time to look into this... :(

Never really had any problems unloading a VSP plugin before :|

-Oh you can remove the hook then at a later time unload the the plugin and it doesn't crash, but if you don't remove the hook (or remove the hook in the Unload() method) it crashes. wtf.


Update: My problem is because the module itself is now being unloaded. It appears some remnants of SourceHook remain active even if you remove all hooks in the Unload() method and then when the module is removed it can no longer access its data.