[Arkshine]

Forward_PutInServer_Post :

- Cache the g_aCommandsHolder[ iPlayers ] value.
- Cache the g_aCvarHolder[ iPlayers ] value.
- In the first part, you could use directly ArrayGetStringHandle(), it will avoid to retrieve the string before.
- In the second part of the code, I would check iSize so it would not create aData if 0.

Forward_Disconnect_Post/Forward_PutInServer_Post :

- Cache the g_aCommandsHolder[ iPlayers ] value.
- Cache the g_aCvarHolder[ iPlayers ] value.
- In the first part, you could use directly ArrayGetStringHandle(), it will avoid to retrieve the string before.
- In the second part of the code, I would check iSize so it would not create aData if 0.
- Cache g_aCvarHolder[ iPlayers ].

Actually since it's basically the same code, you could use one function for both.

Cmd_AddCommand :

- You should retrieve the second argument after the iPlayers check.

Cmd_AddCvar :

- You should retrieve the second argument after the iPlayers check.
- You should retrieve the third argument after the aData check.

[Arkshine]

No changes done. Author seems inactive. Unapproved.

[nikhilgupta345]

Originally Posted by Arkshine Forward_PutInServer_Post : - Cache the g_aCommandsHolder[ iPlayers ] value. - Cache the g_aCvarHolder[ iPlayers ] value. - In the first part, you could use directly ArrayGetStringHandle(), it will avoid to retrieve the string before. - In the second part of the code, I would check iSize so it would not create aData if 0. Forward_Disconnect_Post/Forward_PutInServer_Post : - Cache the g_aCommandsHolder[ iPlayers ] value. - Cache the g_aCvarHolder[ iPlayers ] value. - In the first part, you could use directly ArrayGetStringHandle(), it will avoid to retrieve the string before. - In the second part of the code, I would check iSize so it would not create aData if 0. - Cache g_aCvarHolder[ iPlayers ]. Actually since it's basically the same code, you could use one function for both. Cmd_AddCommand : - You should retrieve the second argument after the iPlayers check. Cmd_AddCvar : - You should retrieve the second argument after the iPlayers check. - You should retrieve the third argument after the aData check.

Done. Updated to v1.1.1.

[Arkshine]

Since you are back, thread moved to Review section, will see later.

[flaxo]

Can you maybe somehow add a timer Cvar which counts the number of players connected after a mapchange, only within X seconds?
For example I'd like to use this plugin together with a Auto-Round Restart plugin. The player_cvars.ini file should be something like this:

[10] (Auto-Restart only if 10+ players are connected) cvar_autorestartpluginenable 1 (The AutoRR's plugin Cvar for plugin enabling) sv_restart 1

However, if during the gameplay the number of players falls below 10 and after a while gets over 10 again, the server will auto-restart again just like a new map change causing some players to dissatisfy and disconnect.
Hope you undestood what I want to say. Thanks in advance

[Arkshine]

Please avoid using ArraySize() in a loop, cache the value.

Anyway, it sounds good enough.

Approved.

[zaludan]

Am I doing something wrong, or it doesn't work with non-default cvars?
I'm trying to make it work with Voices Management (https://forums.alliedmods.net/showth...02274?p=602274) and it just doesn't.