View Single Post
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 01-03-2016 , 10:36   Re: Dragon Ball Z ~ Mod
Reply With Quote #49

You did not provide the needed signature. CheckMapConditions and CheckWinConditions should be hooked from the g_pGameRules object(by providing an offset), not by making signatures.
After patching the memory no restart is needed.

PHP Code:
switch ( GoodRandomClass[id] )
    {
        case 
1ChangeClassidGoku )
        case 
2ChangeClassidVegeta )
        case 
3ChangeClassidTrunks )
        case 
4ChangeClassidGohan )
    } 
Could be done as:
PHP Code:
ChangeClassidGoodRandomClass[id] - 
Same for VillanRandomClass.

In Fw_PlayerSpawn is_user_alive check should be the first one. Also don't use fakemeta_util, use the module functions(give_item, strip_user_weapons, etc).
In fw_TouchWeapon make sure the entity is valid.
You also lack sanity checks inside. fw_TakeDamage.

I'm not going to check more. Unapproved, but if you decide to fix your plugin you can PM me and we will see.
__________________
HamletEagle is offline