Thread: Jarate On Death
View Single Post
DarthNinja
SourceMod Plugin Approver
Join Date: Mar 2009
Location: PreThinkHook()
Old 11-09-2011 , 00:44   Re: Jarate On Death
Reply With Quote #2

A few issues with your plugin if you want it approved:
  1. in your "has" global, use the MAXPLAYERS define, don't hardcode the value at 33.
  2. You don't need to use GetClientName. Please review This Page.
  3. You should use ProcessTargetString, not FindTarget. Please review This Page.
  4. Don't use GetMaxClients(), just use the MaxClients define.

Some extra nitpicks:
  1. You might want to add a version cvar so you can see what servers run your plugin.
  2. You can leave the plugin description and url blank rather then putting filler there.
  3. Your if statement on lines 34/35 is kind of odd.
  4. You should emit the sound from a location otherwise it will play to every player in the server even if they're nowhere around. See EmitSoundToAll for info.
__________________
DarthNinja is offline