Thread: Precache Kit
View Single Post
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-15-2015 , 05:43   Re: Precache Kit
Reply With Quote #5

You used orpheu :O ? Nice...

g_szMapName should be 32, this is the size used by game, if I remember well.
I would create g_tUnPrecache trie outside the if check, if the file doesn't exists it will be invalid and your checks will throw an error(TrieKeyExists(g_tUnPrecache, .....)).
Edit: After testing it seems that server crash when file doesn't exists, you should do as I said to avoid that.

When parsing the file, trim found data because if someone use a space before ";" your check will fail.
Code:
 ;sth
. Here Data[0] is not ; but the line should be ignored.

PHP Code:
formatex(szFilecharsmax(szFile), "%s/unprecacher.ini"szFile
It should be format.

You didn't care to test this properly, because of:
PHP Code:
log_amx("[ PRECACHE KIT ] %s NOT FOUND"
I think you see the mistake.
Use formatex and not format when not formatting in the same buffer from where you get values.
I think that you can use only one trie, instead of 3(models/sound/generic) and set with an identifier(0 for models, 1 for sounds and so on).

You are not saying anything about unprecacher.ini file, it should be created by the user or is this automatically ? Even if in archive, you should add the instructions to the first post.

Just what I saw when fastly reading your code...
__________________

Last edited by HamletEagle; 03-15-2015 at 07:18.
HamletEagle is offline