View Single Post
Nextra
Veteran Member
Join Date: Apr 2008
Location: Germany
Old 10-10-2009 , 05:40   Re: Silence The Dead 1.0.0 (Updated 10-9-09)
Reply With Quote #5

Nice idea but I don't really understand why you already submitted this. All features that would make this plugin unique and stand out are still missing from the code and it seems like it could take it's time until you figured all that stuff out. For now the plugin seems to be in a redundant state.

Some things you could/should do code-wise:
- The cvar std_enable won't work (plugin can't be disabled). You check the cvar value and then return PLUGIN_HANDLED anyway. To let the message pass you need to return PLUGIN_CONTINUE.
- The cvar std_admins won't work (admins can't chat regardless of cvar setting). You check is_user_admin(id) and then return PLUGIN_HANDLED anyway. To let the message pass you need to return PLUGIN_CONTINUE.
- When you catch the death event there is no need to return PLUGIN_HANDLED in any of those situations. Return PLUGIN_CONTINUE.
- If you return PLUGIN_HANDLED change it to PLUGIN_HANDLED_MAIN so chat commands won't be blocked aswell.
- You could combine the if statements into one in both functions (no must have).
- Do ML, should be no hassle for such a small plugin.
__________________
In Flames we trust!

Last edited by Nextra; 10-10-2009 at 05:47.
Nextra is offline