View Single Post
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 08-10-2011 , 06:00   Re: [TF2]TF2items.com MOTD backpack(With player menu)
Reply With Quote #30

Hello.

1.) On line 58 you have the right idea as this will error out if the console runs the command. However, you never return Plugin_Handled so execution continues.

2.) If the target is invalid you're displaying the clients own backpack. Are you sure about this?

3.) In DisplayBackpack you get the targets Auth String, however the functions that you're using to select targets doesn't guarantee they're authorized (FindTarget). So you have the potential of filling itemsurl with garbage.

4.) Adverts default to disabled. If the value isn't changed, the timer is still running with the way it's currently setup.

5.) Why is this labeled as TF2? Wouldn't this work on any game?

Hope this helps, PM me if you fix these.
KyleS is offline