Quote:
Originally Posted by edon1337
Oh, yep, you're right, forgot about the operators being negated, didn't even know that was a thing in Pawn.
|
It's a thing everywhere.
About braces, you need to be consistent. I still see single instruction blocks without them.
I didn't notice before, but the same logic issue is present here:
PHP Code:
if( ! ( is_user_connected( iAttacker ) || is_user_connected( iVictim ) ) )
return HAM_IGNORED;
There's still an error in fw_HamSpawnPost.
Let's assume the plugin is turned on and players can secure their money. Someone secures his money and he doesn't die that round, so he still has g_bHasSafety true. Now, at the end of the round knife_bounty_secure is set to 0.
When fw_HamSpawnPost is called the if check will fail, and g_bHasSafety will not reset, meaning player will be able to have his moneys secured for all rounds as long as he doesn't die.
Probably the best layout for this functions is:
Code:
alive check and plugin enabled check
reset g_bHasSafety
knife_bounty_secure check
print SECURE_AD
__________________