View Single Post
Emp`
AMX Mod X Plugin Approver
Join Date: Aug 2005
Location: Decapod 10
Old 12-14-2006 , 20:56   Re: DoD Shell Shock v1.1
Reply With Quote #9

Requesting that you clean up code such as
Code:
floatdiv(Float:set_time,Float:ten)
edit: also
Code:
		fVec[0] = random_float(get_pcvar_float(p_dod_shellshock_vector_low), get_pcvar_float(p_dod_shellshock_vector_high))
		fVec[1] = random_float(get_pcvar_float(p_dod_shellshock_vector_low), get_pcvar_float(p_dod_shellshock_vector_high))
		fVec[2] = random_float(get_pcvar_float(p_dod_shellshock_vector_low), get_pcvar_float(p_dod_shellshock_vector_high))
could be a lot better as
Code:
		new Float:vec_low = get_pcvar_float(p_dod_shellshock_vector_low)
		new Float:vec_high = get_pcvar_float(p_dod_shellshock_vector_high)
		fVec[0] = random_float(vec_low, vec_high)
		fVec[1] = random_float(vec_low, vec_high)
		fVec[2] = random_float(vec_low, vec_high)

and that you change some cvars to defines (not necessary, but suggested)

Last edited by Emp`; 12-14-2006 at 20:58.
Emp` is offline
Send a message via AIM to Emp` Send a message via MSN to Emp` Send a message via Yahoo to Emp` Send a message via Skype™ to Emp`