View Single Post
bat
Veteran Member
Join Date: Jul 2012
Old 12-10-2013 , 13:04   Re: Knife Levels v1.0.
Reply With Quote #7

Quote:
Originally Posted by Kia View Post
PHP Code:
if ( is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage 8)
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == )
    {
        
SetHamParamFloat(4damage )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 10 )
    {
        
SetHamParamFloat(4damage 10 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 11 )
    {
        
SetHamParamFloat(4damage 11 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 12 )
    {
        
SetHamParamFloat(4damage 12 )
    }
    if ( 
is_valid_playerattacker ) && get_user_weapon(attacker) == CSW_KNIFE && knife_model[attacker] == 13 )
    {
        
SetHamParamFloat(4damage 13 )
    } 
This be can made better, and you know that.

PHP Code:
if(iLevel[id]==0)
    {
        new 
menu menu_createszItem"Knife_Handler" );
        
menu_additem(menu"\wNormal Knife [\yUNLOCKED\w]""");               // Normal Knife
        
menu_additem(menu"\d???? ????? [\rLEVEL 1 REQUIRE\d]""");     // Alien Knife
        
menu_additem(menu"\d?????? ?????? [\rLEVEL 2 REQUIRE\d]""");     // Ellium Dagger
        
menu_additem(menu"\d???? ?????? [\rLEVEL 3 REQUIRE\d]""");     // Dark Dagger
        
menu_additem(menu"\d??????????? ????? [\rLEVEL 4 REQUIRE\d]""");     // Transparent Knife
        
menu_additem(menu"\d??????? ?????? [\rLEVEL 5 REQUIRE\d]""");     // Genuine Dagger
        
menu_additem(menu"\d???? ????? [\rLEVEL 6 REQUIRE\d]""");     // Hunt Blade
        
menu_additem(menu"\d?????? ????? [\rLEVEL 7 REQUIRE\d]""");     // Shadow Blade
        
menu_additem(menu"\d??????????? ??? [\rLEVEL 8 REQUIRE\d]""");     // Slaughterer Axe
        
menu_additem(menu"\d?????? ?????? [\rLEVEL 9 REQUIRE\d]""");     // Golden Katana
        
menu_additem(menu"\d???????? ????? [\rLEVEL 10 REQUIRE\d]""");     // Assasin's Blade
        
menu_additem(menu"\d?????????? [\rLEVEL 11 REQUIRE\d]""");        // Lightsaber
        
menu_additem(menu"\d?????? ????????? ????? [\rLEVEL 12 REQUIRE\d]"""); // Bloody Wolverine Claws
        
menu_additem(menu"\d?????? ??? [\rLEVEL 13 REQUIRE\d]""");     // Proton Axe
        
        
menu_setpropmenuMPROP_EXITMEXIT_ALL );
        
menu_displayidmenu);
    } 
This one too, check for the Level and decide then what string to display, saves much code.

PHP Code:
case 0:{
            
SetKnife(id 0)
            
ColorChat(id,"The knife you chose is: ^4Normal Knife^1.");
        }
        case 
1:{
            
SetKnife(id 1)
            
ColorChat(id,"The knife you chose is: ^4Alien Knife^1.");
        }
        case 
2:{
            
SetKnife(id 2)
            
ColorChat(id,"The knife you chose is: ^4Ellium Dagger^1.");
        }
        case 
3:{
            
SetKnife(id 3)
            
ColorChat(id,"The knife you chose is: ^4Dark Dagger^1.");
        }
        case 
4:{
            
SetKnife(id 4)
            
ColorChat(id,"The knife you chose is: ^4Transparent Knife^1.");
        }
        case 
5:{
            
SetKnife(id 5)
            
ColorChat(id,"The knife you chose is: ^4Genuine Dagger^1.");
        }
        case 
6:{
            
SetKnife(id 6)
            
ColorChat(id,"The knife you chose is: ^4Hunt Blade^1.");
        }
        case 
7:{
            
SetKnife(id 7)
            
ColorChat(id,"The knife you chose is: ^4Shadow Blade^1.");
        }
        case 
8:{
            
SetKnife(id 8)
            
ColorChat(id,"The knife you chose is: ^4Slaughterer Axe^1.");
        }
        case 
9:{
            
SetKnife(id 9)
            
ColorChat(id,"The knife you chose is: ^4Golden Katana^1.");
        }
        case 
10:{
            
SetKnife(id 10)
            
ColorChat(id,"The knife you chose is: ^4Assasin's Blade^1.");
        }
        case 
11:{
            
SetKnife(id 11)
            
ColorChat(id,"The knife you chose is: ^4Lightsaber^1.");
        }
        case 
12:{
            
SetKnife(id 12)
            
ColorChat(id,"The knife you chose is: ^4Bloody Wolverine Claws^1.");
        }
        case 
13:{
            
SetKnife(id 13)
            
ColorChat(id,"The knife you chose is: ^4Proton Axe^1.");
        } 
Same for here.

You have much redundant code in your plugin, review your code and update it.
++
bat is offline
Send a message via Skype™ to bat