For me, it seems useless. If you can explain the purpose it will be good.
1. Your menu is not dinamyc, so you can create it in plugin_cfg.
2. menu_setprop(menu, MPROP_EXIT, MEXIT_ALL); it's default, you don't have to add it.
3.
Code:
new command[6], name[64], access, callback;
menu_item_getinfo(menu, item, access, command, sizeof command - 1, name, sizeof name - 1, callback);
You don't need to get menu info.
4. In color_saytext: cache get_user_msgid("SayText")
5.
Code:
public connectmessage(id)
{
if(is_user_connected(id))
{
color_saytext(id, "^x01[^x04 Server Name ^x01] ^x01Say ^x04/smenu ^x01 to use usefull commands & more.") // After changing clcmd you can edit in this.
}
}
Where are you calling this ? Because, it's not a default amxx forward or sth, so it won't ever get executed. Also, if you want a connect message, set a task to 3.0 seconds from client_putinserver.
I know you are a beginner, it's good to start with easy plugins, this make you want to do more, to advance, but this is crap.
For "[Server Name]" from messages, you can create a cvar, so it would be easy to modify.
And what if the server owners like your plugin but don't like your custom plugins ? You are forcing them to use it.
This may have potential, if it's done corectly. Create a ini file in which peoples can add they own command and menu items name, then create a menu with the file content. You won't need to provide another plugins with your one, so you don't force server owners to use this plugins, everything will be dynamic.