View Single Post
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 10-13-2014 , 17:20   Re: [CS1.6|CZ] Knife Realism v0.0.5 ( 14/10/2014 )
Reply With Quote #42

Let's dig more
  • This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer.
  • There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often.
  • I would cache get_user_team( index ) and get_user_team( iAttacker ) before.
  • In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check.
  • new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags.
  • I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better.
  • Supporting plugin pause/unpause would be welcomed.
__________________

Last edited by Arkshine; 10-13-2014 at 17:20.
Arkshine is offline