Thread
:
DeFRAG [1.0 OUT] // News to come soon!
View Single Post
khios
Junior Member
Join Date: Mar 2009
Location: Belgium
03-18-2009 , 20:06 Re: DeFRAG
#
21
Quote:
Originally Posted by
Nextra
This.
There are currently more than 3 different identation styles in your plugin. You should really take some time to work on the code instead of just pasting everything into one file. I did not look through the entire code but I bet there are enough things that can be done better easily.
Few things I noticed:
- You should put global constants and defines at the top of the file..
- You do not use g_bAlive in the whole code. You want to use a global variable so do not use is_user_alive anymore. Thats an example copy and paste fails and you should review the code.
- There are two register_forward for each post and prethink, one of each without the required function wich will cause errors in plugin_init, often preventing it from executing following code.
- Again, fix your identation and use one (read: your) style accross the whole plugin.
regards.
Thanks Nextra now I know a little bit more what to change and where =)
Will work on it soon
khios
View Public Profile
Send a private message to khios
Find More Posts by khios