Thread: Sample of how NOT to code for approval: XpMod
View Single Post
micke1101
Veteran Member
Join Date: Jan 2008
Location: Banned-town
Old 10-29-2009 , 12:48   Re: XpMod
Reply With Quote #12
Quote:
Originally Posted by Jon View Post
PHP Code:
public LoadData(id) 
{
    if(get_pcvar_num(SaveXp) == 1){
        new AuthID[35];
        get_user_authid(id,AuthID,34);
        new vaultkey[64],vaultdata[256] 
        format(vaultkey,63,"%s-XPMod",AuthID) 
        format(vaultdata,255,"%i#%i#%i#%i#%i#%i#%i#",PlayerXp[id],PlayerLevels[id][1],PlayerLevels[id][2],PlayerLevels[id][3],PlayerLevels[id][4],PlayerLevels[id][5],PlayerLevels[id][6]) 
        fvault_get_data(g_vault,vaultkey,vaultdata,255) 
        replace_all(vaultdata, 255, "#", " ") 
        new playerlxp[32], playerlvl1[32], playerlvl2[32], playerlvl3[32], playerlvl4[32], playerlvl5[32], playerlvl6[32]; 
        parse(vaultdata, playerlxp, 31, playerlvl1, 31, playerlvl2, 31, playerlvl3, 31, playerlvl4, 31, playerlvl5, 31, playerlvl6, 31) 
        PlayerXp[id] = str_to_num(playerlxp);
        PlayerLevels[id][1] = str_to_num(playerlvl1)
        PlayerLevels[id][2] = str_to_num(playerlvl2)
        PlayerLevels[id][3] = str_to_num(playerlvl3)
        PlayerLevels[id][4] = str_to_num(playerlvl4)
        PlayerLevels[id][5] = str_to_num(playerlvl5)
        PlayerLevels[id][6] = str_to_num(playerlvl6)
    }
    if(PlayerLevels[id][1] == 0){
        PlayerLevels[id][1] = 1;
        PlayerXp[id] = get_pcvar_num(StarterXp);
    }
    if(PlayerLevels[id][2] == 0){
        PlayerLevels[id][2] = 1;
    }
    if(PlayerLevels[id][3] == 0){
        PlayerLevels[id][3] = 1;
    }
    if(PlayerLevels[id][4] == 0){
        PlayerLevels[id][4] = 1;
    }
    if(PlayerLevels[id][5] == 0){
        PlayerLevels[id][5] = 1;
    }
    if(PlayerLevels[id][6] == 0){
        PlayerLevels[id][6] = 1;
    }
    if(PlayerLevels[id][1] == 2){
        PlayerPercent[id][1] = get_pcvar_num(PtHealth1);
    }
    if(PlayerLevels[id][1] == 3){
        PlayerPercent[id][1] = get_pcvar_num(PtHealth2);
    }
    if(PlayerLevels[id][1] == 4){
        PlayerPercent[id][1] = get_pcvar_num(PtHealth3);
    }
    if(PlayerLevels[id][1] == 5){
        PlayerPercent[id][1] = get_pcvar_num(PtHealth4);
    }
    if(PlayerLevels[id][1] == 6){
        PlayerPercent[id][1] = get_pcvar_num(PtHealth5);
    }
    if(PlayerLevels[id][2] == 2){
        PlayerPercent[id][2] = get_pcvar_num(PtHe1);
    }
    if(PlayerLevels[id][2] == 3){
        PlayerPercent[id][2] = get_pcvar_num(PtHe2);
    }
    if(PlayerLevels[id][2] == 4){
        PlayerPercent[id][2] = get_pcvar_num(PtHe3);
    }
    if(PlayerLevels[id][2] == 5){
        PlayerPercent[id][2] = get_pcvar_num(PtHe4);
    }
    if(PlayerLevels[id][2] == 6){
        PlayerPercent[id][2] = get_pcvar_num(PtHe5);
    }
    if(PlayerLevels[id][3] == 2){
        PlayerPercent[id][3] = get_pcvar_num(PtFlash11);
    }
    if(PlayerLevels[id][3] == 3){
        PlayerPercent[id][3] = get_pcvar_num(PtFlash12);
    }
    if(PlayerLevels[id][3] == 4){
        PlayerPercent[id][3] = get_pcvar_num(PtFlash13);
    }
    if(PlayerLevels[id][3] == 5){
        PlayerPercent[id][3] = get_pcvar_num(PtFlash14);
    }
    if(PlayerLevels[id][4] == 2){
        PlayerPercent[id][4] = get_pcvar_num(PtFlash21);
    }
    if(PlayerLevels[id][4] == 3){
        PlayerPercent[id][4] = get_pcvar_num(PtFlash22);
    }
    if(PlayerLevels[id][4] == 4){
        PlayerPercent[id][4] = get_pcvar_num(PtFlash23);
    }
    if(PlayerLevels[id][4] == 5){
        PlayerPercent[id][4] = get_pcvar_num(PtFlash24);
    }
    if(PlayerLevels[id][5] == 2){
        PlayerPercent[id][5] = get_pcvar_num(PtSmoke1);
    }
    if(PlayerLevels[id][5] == 3){
        PlayerPercent[id][5] = get_pcvar_num(PtSmoke2);
    }
    if(PlayerLevels[id][5] == 4){
        PlayerPercent[id][5] = get_pcvar_num(PtSmoke3);
    }
    if(PlayerLevels[id][5] == 5){
        PlayerPercent[id][5] = get_pcvar_num(PtSmoke4);
    }
    if(PlayerLevels[id][6] == 2){
        PlayerPercent[id][6] = get_pcvar_num(PtRespawn1);
    }
    if(PlayerLevels[id][6] == 3){
        PlayerPercent[id][6] = get_pcvar_num(PtRespawn2);
    }
    if(PlayerLevels[id][6] == 4){
        PlayerPercent[id][6] = get_pcvar_num(PtRespawn3);
    }
    return PLUGIN_CONTINUE 
}
//The content of the menu
public XpMenu(id) {
    new temp[64];
    formatex( temp, 63, "%L", LANG_PLAYER, "MENU_TITLE");
    new menu = menu_create(temp, "xpmenu_handler");
    if(PlayerLevels[id][1] == 1){XpHealth = get_pcvar_num(XpHealth1); HpHealth = get_pcvar_num(HpHealth1); PtHealth = get_pcvar_num(PtHealth1);}
    if(PlayerLevels[id][1] == 2){XpHealth = get_pcvar_num(XpHealth2); HpHealth = get_pcvar_num(HpHealth2); PtHealth = get_pcvar_num(PtHealth2);}
    if(PlayerLevels[id][1] == 3){XpHealth = get_pcvar_num(XpHealth3); HpHealth = get_pcvar_num(HpHealth3); PtHealth = get_pcvar_num(PtHealth3);}
    if(PlayerLevels[id][1] == 4){XpHealth = get_pcvar_num(XpHealth4); HpHealth = get_pcvar_num(HpHealth4); PtHealth = get_pcvar_num(PtHealth4);}
    if(PlayerLevels[id][1] == 5){XpHealth = get_pcvar_num(XpHealth5); HpHealth = get_pcvar_num(HpHealth5); PtHealth = get_pcvar_num(PtHealth5);}
    if(PlayerLevels[id][2] == 1){XpHe = get_pcvar_num(XpHe1); PtHe = get_pcvar_num(PtHe1);}
    if(PlayerLevels[id][2] == 2){XpHe = get_pcvar_num(XpHe2); PtHe = get_pcvar_num(PtHe2);}
    if(PlayerLevels[id][2] == 3){XpHe = get_pcvar_num(XpHe3); PtHe = get_pcvar_num(PtHe3);}
    if(PlayerLevels[id][2] == 4){XpHe = get_pcvar_num(XpHe4); PtHe = get_pcvar_num(PtHe4);}
    if(PlayerLevels[id][2] == 5){XpHe = get_pcvar_num(XpHe5); PtHe = get_pcvar_num(PtHe5);}
    if(PlayerLevels[id][3] == 1){XpFlashnr1 = get_pcvar_num(XpFlash11); PtFlashnr1 = get_pcvar_num(PtFlash11);}
    if(PlayerLevels[id][3] == 2){XpFlashnr1 = get_pcvar_num(XpFlash12); PtFlashnr1 = get_pcvar_num(PtFlash12);}
    if(PlayerLevels[id][3] == 3){XpFlashnr1 = get_pcvar_num(XpFlash13); PtFlashnr1 = get_pcvar_num(PtFlash13);}
    if(PlayerLevels[id][3] == 4){XpFlashnr1 = get_pcvar_num(XpFlash14); PtFlashnr1 = get_pcvar_num(PtFlash14);}
    if(PlayerLevels[id][4] == 1){XpFlashnr2 = get_pcvar_num(XpFlash21); PtFlashnr2 = get_pcvar_num(PtFlash21);}
    if(PlayerLevels[id][4] == 2){XpFlashnr2 = get_pcvar_num(XpFlash22); PtFlashnr2 = get_pcvar_num(PtFlash22);}
    if(PlayerLevels[id][4] == 3){XpFlashnr2 = get_pcvar_num(XpFlash23); PtFlashnr2 = get_pcvar_num(PtFlash23);}
    if(PlayerLevels[id][4] == 4){XpFlashnr2 = get_pcvar_num(XpFlash24); PtFlashnr2 = get_pcvar_num(PtFlash24);}
    if(PlayerLevels[id][5] == 1){XpSmoke = get_pcvar_num(XpSmoke1); PtSmoke = get_pcvar_num(PtSmoke1);}
    if(PlayerLevels[id][5] == 2){XpSmoke = get_pcvar_num(XpSmoke2); PtSmoke = get_pcvar_num(PtSmoke2);}
    if(PlayerLevels[id][5] == 3){XpSmoke = get_pcvar_num(XpSmoke3); PtSmoke = get_pcvar_num(PtSmoke3);}
    if(PlayerLevels[id][5] == 4){XpSmoke = get_pcvar_num(XpSmoke4); PtSmoke = get_pcvar_num(PtSmoke4);}
    if(PlayerLevels[id][6] == 1){XpRespawn = get_pcvar_num(XpRespawn1); PtRespawn = get_pcvar_num(PtRespawn1);}
    if(PlayerLevels[id][6] == 2){XpRespawn = get_pcvar_num(XpRespawn2); PtRespawn = get_pcvar_num(PtRespawn2);}
    if(PlayerLevels[id][6] == 3){XpRespawn = get_pcvar_num(XpRespawn3); PtRespawn = get_pcvar_num(PtRespawn3);}
    if(PlayerLevels[id][1] < 6){
        formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_HP", HpHealth, PlayerLevels[id][1], XpHealth, PtHealth );
        menu_additem(menu, temp, "1", 0);
    }
    if(cs_get_user_team(id) == CS_TEAM_T){
        if(PlayerLevels[id][2] < 6){
            formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_HE", PlayerLevels[id][2], XpHe, PtHe );
            menu_additem(menu, temp, "2", 0);
        }
        if(PlayerLevels[id][3] < 5){
            formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_FLASH1", PlayerLevels[id][3], XpFlashnr1, PtFlashnr1 );
            menu_additem(menu, temp, "3", 0);
        }
        if(PlayerLevels[id][4] < 5){
            formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_FLASH2", PlayerLevels[id][4], XpFlashnr2, PtFlashnr2 );
            menu_additem(menu, temp, "4", 0);
        }
        if(PlayerLevels[id][5] < 5){
            formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_SMOKE", PlayerLevels[id][5], XpSmoke, PtSmoke );
            menu_additem(menu, temp, "5", 0);
        }
        if(PlayerLevels[id][6] < 4){
            formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_RESPAWN", PlayerLevels[id][6], XpRespawn, PtRespawn );
            menu_additem(menu, temp, "6", 0);
        }
    }
    formatex( temp, 63, "%L", LANG_PLAYER, "MENU_ITEM_INFO");
    menu_additem(menu, temp, "7", 0);
    menu_setprop(menu, MPROP_EXIT, MEXIT_ALL);
    menu_display(id, menu, 0);
} 
No offence, but that's terrible coding. You should really learn more before getting into plugins like this.
I dont like doing that way either but get_pcvar_num can only handle the pcvar itself i wanted to do something like
Code:
PlayerPercent[id][1] = get_pcvar_num(PtHealth%d, PlayerLevels[id][1] - 1);
But that wouldnt work with the way get_pcvar_num() works
micke1101 is offline