I'm done going through the code and like already mentioned above,
it's fine like it is and it does work like it is intended, so this is approved.
I noticed 2 things while testing the plugin though:
- once you "start" the war you setup by menu and the map changes
to the first map in row you have to use the start command again
to actually start the warmup, same after map was reloaded and so on.
Automatically starting the warmup mode after starting the war might
be a future feature request anyways
- after the timelimit was changed, all players are notified about this,
might be unneeded to know for "normal" clanmembers that the timelimit
was set to 0 once the warmup starts and set to X once the actual war starts. Removing the FCVAR_NOTIFY flag from mp_timelimit, changing it
and re-setting the flag would prevent the message from being shown
Other than that it's pretty nice and you saved me a lot of work as
I was working on a ClanMatch plugin for DoD:S as well
