View Single Post
OfficialSikari
Junior Member
Join Date: Aug 2017
Location: /dev/null
Old 04-27-2018 , 16:08   Re: [CSGO] Upgraded & Fixed VIP System - On Database With Perks
#2

First of all, Im not here to tell you what to do, but to point some things out.

Code:
if (StrEqual(gB_SteamID, "BOT"))
    return;
You have this piece of code showing up a few times, you should use IsFakeClient() instead.
This would also be a minor optimization if you do it before GetClientAuthId()


I also noticed that you seem to give your local variables the g prefix while your global variables dont have that, in my opinion those should be quite the other way around.

You also seem to prefix your char arrays b which would indicate that its a boolean.
You should use either sz or c for char arrays, or something else that would better indicate that its a char array.

You seem to give your strings "hardcoded" maxlength instead of using sizeof(). Heres an example of line 973.

You should use sizeof(sTest) instead of giving 512 as the maxlength.

Code:
public Action Timer_ApplySkin(Handle timer, any client)
{
    char sTest[512];
    Format(sTest, 512, "%s", clientskin[client]) // Should fix crashes
    PrecacheModel(sTest);
    SetEntityModel(client, sTest);
}
And again, im not complaining. Im pointing out things.

Last edited by OfficialSikari; 04-27-2018 at 16:09.
OfficialSikari is offline