View Single Post
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 01-09-2017 , 10:22   Re: Temporary Admin - Add admin for x days
Reply With Quote #18

Quote:
Originally Posted by Black Rose View Post
I have to agree with eyal282 that the original one is not that good.
However, even if this one has more functions it's not very well written. Sorry.

Rant:
Why can't people seem to find these amazing functions in core.inc:
native time(&hour=0,&minute=0,&second=0);
native date(&year=0,&month=0,&day=0);

I know people generally assume people are male when talking about them in second person on this forum or in games but seriously... FindHim is a horrible name for a function. FindPlayer or FindPerson would do just fine.

You should look into how to use the new file functions, pcvars and dynamic arrays.
Name the variables descriptively. Combat and Combat2 is used for different times, makes no sense at all.
Why is it named /astatus? Where does the "a" come from? Why not /tempadmin or /admintime, /temptime, /adminstatus, /tempstatus, timestatus or all of them?
What is the point of the prefix if you leave it to default "PREFIX"?

I didn't look through it all, but you can start with that.
This.
__________________
HamletEagle is offline