Thread
:
[ANY] Admin RegAdminCmd Logging (version 1.3) 10 Nov 2014
View Single Post
El Diablo War3Evo
Veteran Member
Join Date: Jun 2013
11-07-2014 , 16:31 Re: [ANY] Admin RegAdminCmd Logging
#
4
Quote:
Originally Posted by
Powerlord
A few issues I can see just from glancing at it:
This leaks a handle because you never close the CommandIterator handle. GetCommandIterator's docs even warns you about this.
It captures all commands, not just admin commands. To avoid this, you need to check the Flags argument to see if any flags are set on the command.
As far as I can tell, this loops from 0 to MaxRegAdminComands no matter how many commands actually exist. Consider using a while loop to avoid this (such as
while(ReadCommandIterator(CmdIter, Name, sizeof(Name), Flags, Desc, sizeof(Desc))
32 is being hard-coded instead of using the MAX_NAME_LENGTH constant.
Okay.. I'll fix this and update it really soon.
__________________
My Plugins
|
Donations via PayPal
Last edited by El Diablo War3Evo; 11-07-2014 at
16:31
.
El Diablo War3Evo
View Public Profile
Send a private message to El Diablo War3Evo
Visit El Diablo War3Evo's homepage!
Find More Posts by El Diablo War3Evo