View Single Post
hiiamu
Member
Join Date: Nov 2018
Old 09-04-2019 , 18:53   Re: [CS:GO] amuJS (better KZTimer Jumpstats)
Reply With Quote #4

Quote:
Originally Posted by OfficialSikari View Post
Yo, truly an epic plugin you've made!

Couple things I want to note:
- Every single menu you've created leaks their menu handle.
- You've copied almost the entire Distbug plugin without crediting the original author at all.
- You've created a database connection for bugged and nonbugged stats, something that could be considered expensive.
- While you've converted the plugin to new syntax, I could argue that its way less readable at its current state.

And top this off, you've created an advertisement to your discord at a 80 second timer, without a convar to even toggle it off.
Overall, like I said, pretty epic!
Next version(4.0.1) will include the following -
  • Credit to GameChaos
  • CVar to change or disable/enable both adverts, meant to remove those before release...
Could you give me some info on what you mean by leaking the menu handle and how it can be affecting things in negative ways, I would like to improve those. Also could you give some pointers to make my plugin more readable?

Last edited by hiiamu; 09-04-2019 at 18:55.
hiiamu is offline