[nosoop]

You can save an indentation level by stripping the surrounding else { /* ... */ } nesting since you're returning from the function early anyways.

There's also the possibility of or-ing the UpgdChoiceBitVec and !bHasAmmoUpgrd result together, and storing the result of UpgdChoiceBitVec may help with readability so it's less characters to read.

Since all the decision making just determines if SelectUpgrd(client, bIsVip); is called or not, you could reduce it down to a couple of boolean variables to check against (even down to a single one if you want to sacrifice readability).

I wouldn't worry about it too much as long as the code works; you'll pick up these things as you learn.