At a quick look:
PHP Code:
if ( g_iVaultHandle == INVALID_HANDLE )
set_fail_state( "Error opening nVault" );
PHP Code:
if( ~ get_user_flags( id ) & FLAG_VIEW )
return PLUGIN_HANDLED;
You already know. Be consistent with { }.
PHP Code:
public plugin_end( )
{
nvault_close( g_iVaultHandle );
}
Indent.
PHP Code:
menu_setprop( iMenu, MPROP_EXIT, MEXIT_ALL );
This is applied automatically. It's not wrong to explicit it tho.
In
MessageStart szArgs and szName are useless. Retrieve the information directly into
eData[ Message_Text ] and
eData[ Message_Sender ].
szMessageCount[ 2 ] szMsgId[2] buffers should be increased, you could have 50/100/1000 messages.
Possible features to add:
-ability for admins to remove a message once they read it
-ability for the sender to see when an admin opened and read his message. Maybe a chat message when he connects/when the message is read if he is connected.