Thread: Close your eyes
View Single Post
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 11-27-2009 , 12:45   Re: Close your eyes
Reply With Quote #5

Nothing to say. Well, just some very minors things :

- MSG_ONE -> MSG_ONE_UNRELIABLE
- You could use one cell instead of array, saving some memory using such thing
Code:
#define SetPlayerBit(%1,%2)    ( %1 |=    1 << ( %2 & 31 ) ) #define ClearPlayerBit(%1,%2)  ( %1 &= ~( 1 << ( %2 & 31 ) ) ) #define GetPlayerBit(%1,%2)    ( %1 &     1 << ( %2 & 31 ) )
- float() is not needed because you divide by a float, so the output will be a float.
- So you allow to block for all screenfade effect. A plugin could emit such event for another purpose. Maybe you should filter since the purpose of the plugin is "to avoid get flashed."
- I don't like much you write '9000' :p ; 1 second being 1 << 12 or 4096, I would like to see when I read your code you don't give random number. I mean It can be useful for people to understand.
- "jrpt" ; I would suggest to use a more speaking cvar like : closeyoureyes_version or close_your_eyes ; I don't know. Because I guess that jrpt stands for joropito ; If you do severals plugin with the same cvar, the meaning to track a specific plugin is null.
__________________

Last edited by Arkshine; 11-27-2009 at 12:55.
Arkshine is offline