Thread: AMX Self Weld
View Single Post
karlos
Veteran Member
Join Date: Apr 2004
Location: Germany/Poland
Old 03-25-2005 , 22:09  
Reply With Quote #2

ripping does not mean copy everything even if completly unneeded

1) in this plugin u can throw away half of the self weld code as it is needed for gnome but not here

2) your mvm check will always return that it is a mvm map cause "find_ent_by_class(0,"team_command")" is always bigger 1
this function only returns the ID of a CC and due to the fact that on a server with more than 1 player: 1 and 2 are player ids so this will return a value bigger 1
rather use ns_get_build(...)

3) im sure u will always have runtime errors due to this
Code:
for ( new id = 0; id <= get_maxplayers(); id++ ){
	if ( pev(id,pev_team) == 1 || is_mvm() ){ //if marines
         if(is_user_connected(id) && is_user_alive(id) && ......)
3a ) a player id is always 1 or bigger and not 0
3b ) before doing any operation in a FOR loop check if player is connected and NOT doing operations and checking later if player is connected

4) due to 1) heavy cant weld above 100 ap and if the have above 100 and start to weld self they will drop down to 100
__________________
alias White Panther
karlos is offline