View Single Post
DarthNinja
SourceMod Plugin Approver
Join Date: Mar 2009
Location: PreThinkHook()
Old 11-04-2011 , 19:50   Re: [TF2] Sleeper Extinguish
Reply With Quote #8

Approved, however a few changes would be good:

  • I'm not sure why any of your IsValidClient check is needed since TF2_CalcIsAttackCritical won't be called unless the client is firing a weapon.
  • Your weapon name check is redundant since you check the item index on the following 2 lines.
  • You might want to add some sort of advertisement message if a player spawns with a Sydney Sleeper so they know they can put teammates out.

Thrawn2 also makes some good suggestions especially the chargelevel cvar.

Also, in your post you have your version cvar and version number in the wrong fields.
__________________

Last edited by DarthNinja; 11-04-2011 at 19:52.
DarthNinja is offline