Quote:
I'll have a chat to BAIL about the possibility of introducing a new forward that gives third party plugins a chance to edit admin permissions before other plugins start reading them.
|
but isn't it OnClientPreAdminCheck that should allow plugins to change users flags?
I think that there's no need in new natives, it's just default user flags assigning should be changed...
this is from admin-sql-threaded.sp
PHP Code:
public Action:OnClientPreAdminCheck(client)
{
...
/**
* If someone has already assigned an admin ID (bad bad bad), don't
* bother waiting.
*/
if (GetUserAdmin(client) != INVALID_ADMIN_ID)
{
return Plugin_Continue;
}
FetchUser(hDatabase, client);
return Plugin_Handled;
}
so maybe user flags assignment shouldn't skip clients who already have temporary admin id, or it should happen before OnClientPreAdminCheck ...
and how can you do any adminchecks if there are no user flags at that moment?
it may even be considered as a bug...
I think that assigning user flags BEFORE OnClientPreAdminCheck would be more appropriate and will allow plugins to change user flags