View Single Post
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 12-06-2015 , 04:54   Re: Fail Spawn Protector v1.0
Reply With Quote #28

1.I would like you to be consistent while coding(keep the same naming technique). For example, on some variables you use HN(g_,i,f, etc) and at some you don't(originF).
2.I also don't think g_bHamHookEnabled is really needed, you can simply Enable the hook at SpawnPre and Disable it in SpawnPost.
3.Also try to understand what you are taking from others. In is_player_trap you do:
PHP Code:
engfunc(EngFunc_TraceHulloriginForiginF0, (pev(idpev_flags) & FL_DUCKING) ? HULL_HEAD HULL_HUMANid0
But you have a PlayerHullSize define, so use it.

Apart of that, code looks ok. I'll wait for you to fix at least 2 and 3, then I'll approve it.
__________________

Last edited by HamletEagle; 12-06-2015 at 04:55.
HamletEagle is offline