|
Veteran Member
Join Date: Sep 2007
Location: Flatland, USA
|
10-14-2015
, 19:47
Re: Multi-Mod Manager v1.0-release_candidate2.hotfix2
|
#4
|
- You should never return a string from a function. Strings should always be passed by-ref with the max characters passed as another parameter. Then, in the function, you would either format directly into that string using the size provided or use copy().
- Don't pass an integer value to a function by putting it in a string. Just pass the integer. E.g. msgResourceActivated(). If the original source of the value is from a string like read_argv() then you should convert it to an integer before passing it to a function like primitiveFunctions().
- If you are going to use the multilingual system to print to the server console, you should not use LANG_PLAYER; that just doesn't make sense. You should use LANG_SERVER.
- This will only work with Counter-Strike (because of color chat) and thus your submission should not be labeled as "Modification: ALL".
- Your code needs to be in English (this is a rule for plugin submissions).
- You should use a switch() in configureMultimod() instead of conditionals because all three cases are mutually exclusive. The third case can be the "default" case.
- IIRC, printing info to the client in a for loop can cause an overflow. Simply build the whole text into a single string and then send that only once. You can create multiple lines by using "^n".
- The use of server_print() should be rare and mostly for debugging. For registered commands, it should only be used with register_srvcmd() (unless it's for debugging of course).
- When you register a command with register_concmd(), you should only use console_print() to output information. Likewise, when you register a command with register_clcmd(), you should only use client_print(id, print_chat, ...) and client_print(id, print_console).
I'm sure there is more but I am done for now.
Quote:
Originally Posted by addons_zz
And even better, server's admins with right flag can change the server's current mod without needing direct access like ftp, to the server's files.
|
lol This is not special. It's just a consequence of doing this sort of thing and can be done with both Polymorph and Joropito's MultiMod (afaik).
__________________
Last edited by fysiks; 10-14-2015 at 19:49.
Reason: typo
|
|
|
|