View Single Post
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 03-17-2012 , 05:04   Re: [ANY] Disco Mod! *Updated: 3/17/12
Reply With Quote #7

Looks impressive, especially with the disco ball model.

I don't mind a few people using my bandwidth, but I'd appreciate if people could host their own MP3s. Can you take my URLs out of your default config?

You might mention that music requires Flash For Other Browsers on the clients.

Could a version be made that doesn't play music, only does the disco effects?

Finally, it'd be nice if you removed the "Made by Mitch" thing in the menu. The majority of people using the plugin won't know who "Mitch" is, and if anyone cares who made it, there's sm plugins.


Feedback on the code:

PHP Code:
public Action:DoUrl(clientString:url[128])
{
    new 
Handle:setup CreateKeyValues("data");
    
    
KvSetString(setup"title""DISCO");
    
KvSetNum(setup"type"MOTDPANEL_TYPE_URL);
    
KvSetString(setup"msg"url);
    
    
ShowVGUIPanel(client"info"setupfalse);
    
CloseHandle(setup);
    return 
Plugin_Handled;

No need for DoUrl to return anything, nor for it to be public. Try this:
PHP Code:
DoUrl(clientString:url[128])
{
    new 
Handle:setup CreateKeyValues("data");
    
    
KvSetString(setup"title""DISCO");
    
KvSetNum(setup"type"MOTDPANEL_TYPE_URL);
    
KvSetString(setup"msg"url);
    
    
ShowVGUIPanel(client"info"setupfalse);
    
CloseHandle(setup);

Why open Google to stop music? Use about:blank.

Provide a command accessible to users to turn off the music. Telling them to type motd won't work if the server has a textual MOTD or if basetriggers isn't running.

Please don't use a cvar for access to a command. Use RegAdminCmd instead and we can continue using our override system.
__________________

Last edited by Dr. McKay; 03-17-2012 at 05:11.
Dr. McKay is offline