View Single Post
Eun
Member
Join Date: Jan 2011
Old 06-24-2015 , 04:51   Re: [INC] DString - Dynamic Strings
Reply With Quote #5

I appreciate your changes.
But there are some problems:


Quote:
Originally Posted by Emp` View Post
  1. Rewritten to not use multiple cell packing. This should reduce plugin weight by doing less native calls. The drawback is that some functions have a max length at DSTRING_BUFFERLEN, which is arbitrarily high at 4048, so you probably will not reach it.
I guess you should not limit the Developer to an "arbitrarily high" buffer. Thats not the use case of this Module. This Module should give you the theoretical possibility to use string with an unspecified length.
You just limited it to 4084

Quote:
Originally Posted by Emp` View Post
  1. Renamed DString_ADDEXBUFFER to DSTRING_BUFFERLEN.
The buffer was especially designed just for AddEx, since we cannot be dynamic on Formatting issues.


Additionaly you never should fill buffers in a Length call. Length operations should be as little as possible.


However, I added the MethodMap.

Last edited by Eun; 06-24-2015 at 04:52.
Eun is offline