Quote:
Originally Posted by Peace-Maker
Nicely structured plugin!
Some notes after skimming over it (they're not that important):
- You register sm_fwfixdb twice and just return "Not implemented" :D why?
- Line 1113: why do you get the sendprop offset there?
- Please cache offsets returned by FindSendPropOffset or just use SetEntProp over SetEntData.
- It might be just me, but that blocking of code chunks with { } isn't helping readability.
- When requiring <fortwars> in your modules, you don't have to keep track of the library being added/removed. If the core plugin is unloaded, all dependent plugins are set into a failstate too and are paused. They won't even load, if the required core isn't running. You should only call any natives out of fortwars in OnAllPluginsLoaded instead of OnPluginStart.
Keep it up:) |
Well, the plugin is from 2009, so I'm not even maintaining it anymore :P
That remembers me to unsubscribe to this thread, since I don't even play tf2 anymore...