View Single Post
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 10-06-2012 , 17:00   Re: [TF2] FortWars (v6.52)
Reply With Quote #214

Nicely structured plugin!
Some notes after skimming over it (they're not that important):
  • You register sm_fwfixdb twice and just return "Not implemented" why?
  • Line 1113: why do you get the sendprop offset there?
    • Please cache offsets returned by FindSendPropOffset or just use SetEntProp over SetEntData.
  • It might be just me, but that blocking of code chunks with { } isn't helping readability.
  • When requiring <fortwars> in your modules, you don't have to keep track of the library being added/removed. If the core plugin is unloaded, all dependent plugins are set into a failstate too and are paused. They won't even load, if the required core isn't running. You should only call any natives out of fortwars in OnAllPluginsLoaded instead of OnPluginStart.
Keep it up
__________________
Peace-Maker is offline