AlliedModders - View Single Post

swapped · 04-16-2014 , 23:55 Re: Glow Health [ v1.0 ]

Quote:

Originally Posted by Sun Aloe

I think a cvar to define if you want this to work between everyone or just teammates would be good.

will be aded in 1.1

Quote:

Originally Posted by Buckshot

Why does every title have a wrench photo? It does not make sence.. It would fit at cvars, but it doesn't make sence in the other places..

Also i wanna ask some questions about ur code.. here are some examples.....

Code:

stock colorx(id, color1,color2,color3)
{
    set_user_rendering(id,kRenderFxGlowShell,color1,color2,color3,kRenderNormal,25)
}

Code:

RemoveGlow( id ) 
{
    set_user_rendering(id,kRenderFxGlowShell,0,0,0,kRenderNormal,25) 
}

Code:

RegisterCvars()
{
    bot_cvar       = register_cvar("gh_bot_show","1")
    red_health_cvar     = register_cvar("gh_red","25")
    green_health_cvar   = register_cvar("gh_green","100")
    yellow_health_cvar  = register_cvar("gh_yellow","70")
}

RegisterHamEvents()
{
    RegisterHam(Ham_Spawn, "player", "hk_spawn", 1)
    RegisterHam(Ham_Killed, "player", "hk_dead", 1)
}



public plugin_init()
{
RegisterCvars()
RegisterHamEvents()
}

That question is WHY?

WHY do you create separate functions and stocks instead of writing ONE single line of code.. ? Most of the functions, and all of the stocks in your code are completely useless...

Also.. This is not needed:

Code:

public client_disconnect( id )
{
    RemoveGlow( id );   
}

and this is not needed either. In client_putinserver:

Code:

         else
    {
        RemoveGlow( id );
    }

I see a code exact like my code writed not in the same line in a Exolent plugin so dont comment if you dont have experience.
About my "bad code" if this is true , please tell me where to update my source.
thanks for some optimization , updated to v1.1 !