View Single Post
OciXCrom
Veteran Member
Join Date: Oct 2013
Location: Macedonia
Old 04-09-2020 , 09:55   Re: [New Plugin Submissions] Help needed
Reply With Quote #20

https://forums.alliedmods.net/showthread.php?t=249160 - bad code; too simple to be approved.
https://forums.alliedmods.net/showthread.php?t=242344 - lacks (proper) description.
https://forums.alliedmods.net/showthread.php?t=249538 - the plugin has ~40 cvars, none of them are mentioned in the thread.
https://forums.alliedmods.net/showthread.php?t=271179 - not a standalone plugin; lacks description on how to run; non-English messages inside the plugin.
https://forums.alliedmods.net/showthread.php?t=187274 - more advanced version here.
https://forums.alliedmods.net/showthread.php?t=143645 - too simple; more advanced plugins exist (example).
https://forums.alliedmods.net/showthread.php?t=312786 - same as above.
https://forums.alliedmods.net/showthread.php?t=182799 - not enough changes from original code; most of them can be done with the default plugin; better alternative.
https://forums.alliedmods.net/showthread.php?t=244222 - doesn't look complex enough; usage of magic numbers; overall bad coding.
https://forums.alliedmods.net/showthread.php?t=280744 - joke plugin; looks like something that can give players a seizure
https://forums.alliedmods.net/showthread.php?t=279614 - not sure about this one; code looks very good and has many useful features, but we already have an approved knife plugin which when combined with this and this exceeds its possibilities by a lot and contains all of its features.
https://forums.alliedmods.net/showthread.php?t=285015 - looks too simple in comparison to other XP plugins.
https://forums.alliedmods.net/showthread.php?t=290169 - too simple; hardcoded and poorly coded.
https://forums.alliedmods.net/showthread.php?t=289440 - reduntant; more advanced plugins exist.
https://forums.alliedmods.net/showthread.php?t=279756 - trash.

@thEsp - although it's not something that will make the code itself better, it definitely helps reach more people that may not understand English; makes the end-user able to modify the messages without touching the .sma file and engages other people to easily contribute to the plugin.

I think we should have more strict standards like the ones I mentioned. Maybe even create a new thread with some general rules and requirements. I know there's one made back in 2005, but AMXX coding standards have changed a lot since then.
__________________

Last edited by OciXCrom; 04-09-2020 at 09:56.
OciXCrom is offline
Send a message via Skype™ to OciXCrom