View Single Post
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 03-02-2015 , 23:26   Re: [CSS/CSGO/?] Admin / Joinsound
Reply With Quote #13

Hey,

Please fix the following for approval :
  • Use user id / serial id for timer, instead of client id. Currently a race condition is possible (client A join, client A leave, client B join and has client A's callback executed). You may want to take a look at GetClientOfUserId and GetClientUserId
  • Mention in your first posts the autoexecconfig library that you're using (a link, for transparence)

On a side note, I was surprised that
Code:
RegConsoleCmd(sBuffer, Command_StopSound);
did not generate errors (SM handles multiple definition )

You could have also used a single buffer in OnConfigsExecuted (Format/FormatEx/strcopy all adds a \0, don't worry)

Red
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline