Thread: CS
View Single Post
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 10-02-2014 , 12:49   Re: CS : [DJ mod]
Reply With Quote #7

Code looks like it has been done years ago. Quite poorly coded.

Fast tips:

- Use cvar pointer
- Use charsmax() instead of hardcoded buffer length
- Stop to glue code together, learn to use new line.
- Use parse() instead of strbreak + replace x2
- Quite dumb to open file with fopen and checking if file exist after with file_exists
- Use formatex when you can
- Don't declare variables in loop
- Use player's index or LANG_PLAYER (if 0) instead of LANG_SERVER.
- No point to call each time get_user_msgid
- ... more and more.
__________________
Arkshine is offline