Thread
:
Suicide Bomb Shop [v1.4] Update: 8/30/2011
View Single Post
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
10-04-2011 , 11:05 Re: Suicide Bomb Shop [v1.4] Update: 8/30/2011
To be approved :
Your menu is static, so you need to generate it only one time.
No need to use
menu_item_getinfo
, you can
item
directly.
In Event_Flashlight :
I don't see why you block the flashlight if not alive. It's unrelated to your plugin. You should have something like : g_HasBomb + g_RoundEnded + is_user_alive.
What is the point to do
g_BombTimer[id] < 3
when you set before to 3. It will never happen. Fix it.
In CountDownExplode :
Avoid to create variable in a loop.
The param passed is the task id. Writing 'id' is not a good idea. More readable and understanding to write something like 'taskid', then doing 'new id = taskid - BOMB.
Returning a value is pointless here. Just return alone for the first check is enough.
After get_distance check, you make 2 checks. Since you do the same thing for both checks, just make the conditions on one line. (||)
Use MSG_PVS for TE_TAREXPLOSION, no need to show something to players not looking at this origin.
Cache the DeathMsg message index.
Unapproved for now.
__________________
Arkshine
View Public Profile
Send a private message to Arkshine
Find More Posts by Arkshine