Re: Random Map on Server Startup
Every plugin can break or have a bug. Just because it's simple doesn't guarantee anything.
|
Re: Random Map on Server Startup
v1.12 released
|
Re: Random Map on Server Startup
Hehe, its a cool idea, give him a shot. Unapprove it later if he shows that he can't handel it. But if he can, hell give him a shot, You don't know if you don't give him a try ;)
|
Re: Random Map on Server Startup
Quote:
Code:
What's this? Why not just use pcvars? Code:
Uhh... why not just combine the RandomMap() function call into the if statement, which also justifies putting brackets in it? Also, why did you return PLUGIN_HANDLED? Why did you even return PLUGIN_CONTINUE? If you HAD to do this, the fastest way (typing-wise) would probably be to just use "return". Code:
Okay, you got me here. Why is it public? Is it called anywhere outside of the plugin? Is it a forward? No? Drop the "public" keyword. Code:
I not only don't get why you don't just do this: Code:
But I don't get why you missed a simple thing like the risk of a buffer overflow. You don't declare an array as 256 then use 256 as the max length, it's 255 to allow for the null terminator. Code:
Why return PLUGIN_HANDLED? There's no point, the return value doesn't do anything. On top of that, you should use log_amx for people who don't have direct access to the console. It might also be a good idea to use copy instead of format, since there are no variables. Code:
Nothing really too wrong here, but if I were to do it, I would have declared the variables like this to save space: Code:
It's also probably better to use the "random" function, since you don't have to push an additional parameter onto the stack. The usage would be something like "random(size)" Code:
This may confuse server owners who think they should set this. Not really any way around it that I can think of, but also you should either use log_amx or just remove the server_print section entirely. Code:
Useless, if you avoided the return that I mentioned earlier, you wouldn't need this. In conclusion, this is staying here. |
Re: Random Map on Server Startup
Uhh, if I remove
Code:
You must end the current function with return if you don't want any other code to be executed. But meh, I like PHP better, I always thought of return PLUGIN_HANDLED as the equivalent to die(); Besides, do you see any other map randomisers? Well I don't, so if you can do better, please do, and who cares about an overflow, as soon as the map changes the damn plugin disables itself. |
Re: Random Map on Server Startup
Quote:
You don't need the return statement because it can be rewritten: Code:
-> Code:
If you don't want to fix the overflow, that's fine with me. This won't stand a prayer in hell of being approved, though. |
Re: Random Map on Server Startup
v1.2.0 released.
|
Re: Random Map on Server Startup
Also, I didn't notice at first but you can do:
Code:
Instead of your crazy stuff. |
Re: Random Map on Server Startup
Quote:
v1.2.1 released. |
Re: Random Map on Server Startup
v1.2.5 released.
PS: Hawk552, what is the difference with pcvars and cvars? |
| All times are GMT -4. The time now is 08:36. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.