AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   Snippets and Tutorials (https://forums.alliedmods.net/forumdisplay.php?f=112)
-   -   [INC] ColorLib (https://forums.alliedmods.net/showthread.php?t=320842)

Ilusion9 02-06-2020 06:35

Re: [INC] ColorLib
 
It seems there's an error with CSayText2 function:

PHP Code:

Exception reportedInvalid field "params" for message "CCSUsrMsg_SayText2" 

You should use: UserMessageToProtobuf() function (see multicolors) instead of view_as<Protobuf>

c0rp3n 02-09-2020 07:55

Re: [INC] ColorLib
 
Quote:

Originally Posted by Ilusion9 (Post 2682911)
It seems there's an error with CSayText2 function:

PHP Code:

Exception reportedInvalid field "params" for message "CCSUsrMsg_SayText2" 

You should use: UserMessageToProtobuf() function (see multicolors) instead of view_as<Protobuf>


Thanks for the report, this is now fixed on the git, as well as another issue from Bara where the 'z' flag wasnt working for CPrintToChatAdmins, there is also an example GitHub workflow for building the color_map.inc in your actions.

TheDS1337 02-10-2020 14:43

Re: [INC] ColorLib
 
If you write %t to include translations it won't work, it only works with %T, I hope you add support for %t if plausible.

Ilusion9 02-11-2020 11:21

Re: [INC] ColorLib
 
Quote:

Originally Posted by TheDS1337 (Post 2683324)
If you write %t to include translations it won't work, it only works with %T, I hope you add support for %t if plausible.

What function? CPrintToChat?
I see there's SetGlobalTransTarget, that should do it for %t.

Ilusion9 02-20-2020 13:21

Re: [INC] ColorLib
 
CRemoveTags doesn't work well for me. If there's no tags, the first index is removed (ex: for my name "Ilusion" appears "lusion"). Maybe use a buffer and construct again the message like in CFormat function?

c0rp3n 02-21-2020 05:04

Re: [INC] ColorLib
 
Yeah I've gone though and fixed the issue, was to do with me checking if the index's are the same and skipping copying values, this has now been sorted along with adding a new function to remove color escape codes from a message `CRemoveColors`.
Also there was an additional bug fix for CSayText2 where I was calling SetString on the proto buffer instead of AddString for the params. This was why you had the error before, didnt notice it as rarely use CPrintToChatEx in code, I have gone back to using view_as<ProtoBuff> for now as the check done by UserMessageToProtobuf is already done in _CL_SupportsProtoBuf.

Ilusion9 02-21-2020 06:51

Re: [INC] ColorLib
 
Have you thought about checking if the color is valid? If not, keep the tag.
Something like:

PHP Code:

bool _CL_ColorMap(char color[16], char &hexColor)
{




c0rp3n 02-22-2020 08:30

Re: [INC] ColorLib
 
Made the change to keep bad / incorrect color tags, but just using 0 or well null, `CPrintToChat(client, "{bad tag here}Hello {green}World");` will remove green but `bad tag here` would stay.


All times are GMT -4. The time now is 22:22.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.