AlliedModders - [Solved] Duplicated reading?

AlliedModders (https://forums.alliedmods.net/index.php)

- Scripting Help (https://forums.alliedmods.net/forumdisplay.php?f=11)

- - Solved Duplicated reading? (https://forums.alliedmods.net/showthread.php?t=310086)

Duplicated reading?

For some reason my code gets duplicated, so if the original line that we have is like this

PHP Code:


		
			
;"Name" "Pw" "AccessFlags" "Prefix"

It becomes

PHP Code:


		
			
"Name" "Pw" "AccessFlags" "Prefix"

"Name" "Pw" "AccessFlags" "Prefix"

// blank line

Instead of just (removed ;)

PHP Code:


		
			
"Name" "Pw" "AccessFlags" "Prefix"

Basically #1 log gets called twice while it should be called once, and I have no idea what makes the file read the same line twice.

PHP Code:


		
			
UnSuspendPlayer( const id )

{

    new const szTempFileName[ ] = "tempfile.ini";



    new szConfigs[ 32 ], szFormat[ 64 ], szData[ 128 ], szDataName[ 32 ], szDataPw[ 32 ], szDataFlags[ 32 ], szDataPrefix[ 32 ], szPlayerName[ 32 ];

    get_configsdir( szConfigs, charsmax( szConfigs ) );

    

    new szTempFilePath[ 256 ]; 

    formatex( szTempFilePath, charsmax( szTempFilePath ), "%s/%s", szConfigs, szTempFileName );

    

    get_user_name( id, szPlayerName, charsmax( szPlayerName ) );

    

    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );

    new iFilePointer = fopen( szFormat, "rt" );

    

    if( iFilePointer )

    {

        new iInputFilePointer = fopen( szTempFilePath, "wt" );

        

        if( iInputFilePointer )

        {

            while( ! feof( iFilePointer ) )

            {            

                fgets( iFilePointer, szData, charsmax( szData ) );

                trim( szData );

                

                parse( szData, szDataName, charsmax( szDataName ), szDataPw, charsmax( szDataPw ), szDataFlags, charsmax( szDataFlags ), szDataPrefix, charsmax( szDataPrefix ) );

                

                log_to_file( "unsusp.txt", "#1 Called" );

                                

                if( szDataName[ 0 ] == ';' ) // check if name has ; in it (;"DoNii" becomes ";DoNii")

                {                    

                    if( equal( szDataName[ 1 ], szPlayerName ) ) // found the admin that we're searching for

                    {

                        fprintf( iInputFilePointer, "^"%s^" ^"%s^" ^"%s^" ^"%s^"^n", szDataName[ 1 ], szDataPw, szDataFlags, szDataPrefix ); // write to new file without ;

                        log_to_file( "unsusp.txt", "#3 %s", szDataName );

                    }

                    

                    else // not the person we're looking for

                    {

                        fprintf( iInputFilePointer, ";^"%s^" ^"%s^" ^"%s^" ^"%s^"^n", szDataName, szDataPw, szDataFlags, szDataPrefix ); // write as it was before

                        log_to_file( "unsusp.txt", "#3 %s", szDataName );

                    }

                }

                

                else // doesnt contain ;

                {

                    fprintf( iInputFilePointer, "^"%s^" ^"%s^" ^"%s^" ^"%s^"^n", szDataName, szDataPw, szDataFlags, szDataPrefix ); // unknown admin, write as is

                    log_to_file( "unsusp.txt", "#2 %s", szDataName );

                }

            }

            fclose( iInputFilePointer );

            fclose( iFilePointer );



            delete_file( szFormat );

            rename_file( szTempFilePath, szFormat, 1 );

        }

    }

    return 0;

}

Code:

L 08/18/2018 - 15:29:04: #1 Called

L 08/18/2018 - 15:29:04: #3 DoNii

L 08/18/2018 - 15:29:04: #1 Called

L 08/18/2018 - 15:29:04: #2 DoNii

Re: Duplicated reading?

To simplify your code you can use "if(szDataName[0] == ';')" and "equal(szDataName[1], szPlayerName )" without having to remove the semicolon.

Re: Duplicated reading?

Quote:

Originally Posted by PartialCloning (Post 2610917)

To simplify your code you can use "if(szDataName[0] == ';')" and "equal(szDataName[1], szPlayerName )" without having to remove the semicolon.

Thanks for the optimization

Re: Duplicated reading?

Instead of

PHP Code:


		
			
while( ! feof( iFilePointer ) )

try

PHP Code:


		
			
while( fgets( iFilePointer, szData, charsmax( szData ) ) )

and remove the fgets call from below that line.

Re: Duplicated reading?

Quote:

Originally Posted by KliPPy (Post 2610934)

Instead of

PHP Code:


		
			
while( ! feof( iFilePointer ) )

try

PHP Code:


		
			
while( fgets( iFilePointer, szData, charsmax( szData ) ) )

and remove the fgets call from below that line.

Worked, thanks, what causes feof to do that?

Re: Duplicated reading?

Google "while feof" (it's same in C) , it's a common problem.

Re: Duplicated reading?

Quote:

Originally Posted by KliPPy (Post 2610957)

Google "while feof" (it's same in C) , it's a common problem.

Everyone uses it though

Re: Duplicated reading?

They shouldn't for reading a file line by line.

Re: Duplicated reading?

Quote:

Originally Posted by KliPPy (Post 2610966)

They shouldn't for reading a file line by line.

I have a question related to this,

let's say we have this line

PHP Code:


		
			
;"Msg1" "Msg2" "Msg3" "Msg4" // Important info

Now that code will turn that into this

PHP Code:


		
			
"Msg1" "Msg2" "Msg3" "Msg4"

Any chance we can transfer // Important info to the new file too?

Re: Duplicated reading?

What do you mean? The entire line should be copied.